python: Include config.h for strlcpy definition #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no definition of strlcpy is found and the local version is used, compiling python/dnet.c triggers a warning in the preprocessor: ./dnet.c:3649:3: warning: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration] Fix this by including the generated config.h which does define strlcpy.
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Sep 26, 2020
Package-Manager: Portage-3.0.8, Repoman-3.0.1 Bug: ofalk/libdnet#60 Signed-off-by: Jeroen Roovers <jer@gentoo.org>
|
Thanks for the PR - it's going to be merged! Thanks a lot for spotting this issue as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no definition of strlcpy is found and the local version is used,
compiling python/dnet.c triggers a warning in the preprocessor:
./dnet.c:3649:3: warning: implicit declaration of function ‘strlcpy’;
did you mean ‘strncpy’? [-Wimplicit-function-declaration]
Fix this by including the generated config.h which does define strlcpy.