Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brute force encryption key automatically #52

Merged
merged 4 commits into from Dec 5, 2021
Merged

Conversation

ofalvai
Copy link
Owner

@ofalvai ofalvai commented Dec 4, 2021

Context: #46

Changes

  • Remove "Use encryption" and "encryption key" config inputs
  • Detect if ?encrypted=1 needed or not for requests
  • If needed, brute force encryption key based on the encrypted response
  • Also handles the case of Problem with candy oven, no key required #35 where ?encrypted=1 is required but the response is not encrypted, just hex encoded

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #52 (fd5bb09) into main (71e8ccf) will increase coverage by 3.27%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   94.20%   97.47%   +3.27%     
==========================================
  Files           6        7       +1     
  Lines         518      595      +77     
==========================================
+ Hits          488      580      +92     
+ Misses         30       15      -15     
Impacted Files Coverage Δ
custom_components/candy/client/__init__.py 92.64% <92.10%> (+13.10%) ⬆️
custom_components/candy/client/decryption.py 100.00% <100.00%> (ø)
custom_components/candy/config_flow.py 100.00% <100.00%> (+39.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e8ccf...fd5bb09. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ manifest.json file exist
✅ All required keys are present in manifest.json
✅ hacs.json has the 'name' key set
✅ The repository has a description
✅ candy is added to https://github.com/home-assistant/brands NICE!
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Sunday)
✅ README.md exists
✅ Requirements validation
✅ HACS load check

@ofalvai ofalvai merged commit a835bee into main Dec 5, 2021
@ofalvai ofalvai deleted the detect-encryption branch December 5, 2021 17:51
@hellmind
Copy link

What if I want to put it manually

@ofalvai
Copy link
Owner Author

ofalvai commented Jan 26, 2022

@hellmind Can you describe why you'd want to provide the key manually?

@hellmind
Copy link

because I get BAD REQUEST

#57

@Powerdrift777
Copy link

Same issue with HBWOS 69TMET-80 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants