Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access token can be set using query builder helper #2

Closed
shadowhand opened this issue Nov 22, 2016 · 1 comment
Closed

Access token can be set using query builder helper #2

shadowhand opened this issue Nov 22, 2016 · 1 comment
Assignees
Labels

Comments

@shadowhand
Copy link

shadowhand commented Nov 22, 2016

The buildQueryString method is available for setting query strings. This code can be replaced with:

$url = $this->domain.self::PATH_API_USER.'?'.$this->buildQueryString([
    'access_token' => $token->getToken(),
]);

This will ensure that the token value is encoded properly for query strings, should the token contain unsafe characters.

@ofbeaton ofbeaton added the bug label Nov 22, 2016
@ofbeaton ofbeaton self-assigned this Nov 22, 2016
@ofbeaton
Copy link
Owner

Thanks for the report and code submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants