Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max-retry-sleep gcsfuse flag #64

Merged
merged 8 commits into from Feb 23, 2021

Conversation

hayorov
Copy link
Contributor

@hayorov hayorov commented Feb 23, 2021

This PR implements --max-retry-sleep gcsfuse flag passthrough.
The flag was introduced in 0.30 + and controls file upload retries and should affect memory consumption GoogleCloudPlatform/gcsfuse#467

  • minor markdown format update.

Doc GoogleCloudPlatform/gcsfuse#495

@hayorov hayorov force-pushed the feature/fuse-flags-passthough branch from 9ce82fd to 7f7d868 Compare February 23, 2021 06:46
@ToxicWar
Copy link
Contributor

Works as expected with providing --max-retry-sleep=0 in mountOptions.
Memory doesn't have any consumption spike anymore.

@maennchen
Copy link
Collaborator

@ToxicWar Thanks again. I'll add a comment about the Flag into the Changelog.

@maennchen maennchen merged commit 9593377 into ofek:master Feb 23, 2021
@maennchen
Copy link
Collaborator

@ToxicWar Released as v0.7.0

@hayorov hayorov deleted the feature/fuse-flags-passthough branch February 23, 2021 14:05
@ofek
Copy link
Owner

ofek commented Feb 23, 2021

Thanks!

@georok georok mentioned this pull request Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants