Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VID/PID for Mustang LT 40S #19

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

tim-littlefair
Copy link
Contributor

I own this model, and I've discovered the PID/VID for it. I realize this isn't a particularly major contribution, but I'm putting it out there as a means of opening communication, because I'm interested in reverse engineering in general, and in getting support for my own amp integrated in particular.

I've also done some Wireshark captures for the model, and will shortly invite you (https://github.com/offa) to have access to my (presently private) github repo where the captures are shared. I'm more than happy for you to copy, publish and use these with or without attribution to myself.

I'm nervous about damaging my amp, so I'm planning to see whether the knowledge I get can be integrated into piorekf's upstream codebase rather than yours in the first instance. My logic for trusting piorekf's codebase (slightly) more is that it is present in Debian and Ubuntu, probabily has a wider install base and I'd hope we'd have heard by now if anyone had mucked about with it and damaged their amp, but I'm still grateful for your update and completely open to experimenting with it at some later date.

Anyway, thanks again and best wishes with the project.

@offa offa merged commit 1002e9d into offa:master Sep 3, 2023
6 checks passed
@offa
Copy link
Owner

offa commented Sep 3, 2023

Thanks! 👍

I usually don't work on private projects as doing it as a community provides more knowledge.

because I'm interested in reverse engineering in general, and in getting support for my own amp integrated in particular.

👍 Newer Mustang devices seem to use a slightly different, but similar protocol. So figuring out the packet structures and stages is a good first step. Maybe you can get some help from the old protocol too.

I'm nervous about damaging my amp,

Capturing packages or sending your own to the amp shouldn't damage it (no guarantee though). I have sent quite some garbage without damaging the device 😄. The only part which could brick your device is the updater, but normal communications shouldn't do any harm.

so I'm planning to see whether the knowledge I get can be integrated into piorekf's upstream codebase

As far as I know this wont work. The upstream project has gone for years now (thus this fork). But I can't speak for Debian / Ubuntu based development here.

@tim-littlefair
Copy link
Contributor Author

tim-littlefair commented Sep 4, 2023 via email

@tim-littlefair
Copy link
Contributor Author

tim-littlefair commented Sep 4, 2023 via email

@offa
Copy link
Owner

offa commented Sep 5, 2023

Although... the link to initialization.log on pioroekf's site has gone to
link rot and wayback doesn't seem to have a copy - if you have any captures
you can share for the amp versions which interoperate with your code or
piorekf's it might help me to work out how the protocol has changed and
turn that round to appropriate changes in either your or piorekf's code -
as I only have a modern amp I don't have a known-good working dump of the
initialization phase frome the original generation - and Technicalities.md
isn't that helpful until I have initialized and am looking at syncing sound
modes.

A good starting point is the initialization phase. Older Mustang devices use 64 byte packets with two fixed initialization packets. Packet and PacketSerializer implement those formats so maybe you can compare them with your captures.

Also, in relation to why my effort is private - if it became something I
had any pride in I would make it public. But not until then.

Don't be shy :-) Even if it's just some dump files it wont hurt being public (just make sure you don't publish any private data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants