searchsploit --json <query> is not valid JSON

[rmetzler]

When the --json switch is used to get JSON formatted output, it's not valid JSON, because there are are two double quotes after the value for "Exploit":

$ searchsploit --json WordPress
{
  "SEARCH": "WordPress",
  "RESULTS": [
                {"Exploit":"WordPress 2.9 - Denial of Service"","Path":"/usr/local/Cellar/exploitdb/2016-12-02/share/exploitdb/platforms/php/dos/10825.sh","EDB-ID":10825},
                {"Exploit":"WordPress 4.0 - Denial of Service"","Path":"/usr/local/Cellar/exploitdb/2016-12-02/share/exploitdb/platforms/php/dos/35413.php","EDB-ID":35413},

...

Using jq will tell you there is a problem parsing the resulting JSON.

I didn't found out where the value came from, but I can provide a workaround:

in Line 632 of searchsploit I added another sed command to substitute "", for ",:

-    | sed '$ s/,$//g' )"
+    | sed -e '$ s/,$//g' -e 's/\"\",/\",/g' )"

I can provide a pull request if you want.

[g0tmi1k]

Thanks for the heads up, will look into it at the weekend (at the latest).

[g0tmi1k]

Sorted!

[ghost]

In line 681
OUTPUT="$( eval ${SEARCH} | awk -F ',' '{ printf "\r\t\t'{'\"Exploit\":\"%s\",\"Platform\":\"%s\",\"Type\":\"%s\",\"Date\":\"%s\",\"Path\":\"'${gitpath}/'%s\",\"EDB-ID\":%s},\n", $3, $5, $6, $4, $2, $1 }' | sed '$ s/,$//g' )"

change to below code
OUTPUT="$( eval ${SEARCH} | awk -F ',' '{ printf "\r\t\t'{'\"Exploit\":\"%s\",\"Platform\":\"%s\",\"Type\":\"%s\",\"Date\":\"%s\",\"Path\":\"'${gitpath}/'%s\",\"EDB-ID\":%s},\n", $3, $5, $6, $4, $2, $1 }' | sed '$ s/,$//g' | sed 's|\\|\//|g' )"

It's work.