Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS add-in ribbon icons are rendering the default image on the classic Outlook for Windows #4446

Closed
1 of 3 tasks
bchen-hs-eng opened this issue May 14, 2024 · 7 comments
Closed
1 of 3 tasks
Assignees
Labels
Area: Outlook Issue related to Outlook add-ins Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: no recent activity Issue or PR is stale (no recent activity)

Comments

@bchen-hs-eng
Copy link

Provide required information needed to triage your issue

On the classic Outlook for Windows, JS based add-in entries on the ribbon are showing the default images.

Your Environment

  • Platform [PC desktop, Mac, iOS, Office on the web]: PC desktop
  • Host [Excel, Word, PowerPoint, etc.]: Outlook
  • Office version number: 2404 (Build 17531.20140 Click-to-Run)
  • Operating System: Windows 11
  • Browser (if using Office on the web): ______

Expected behavior

Add-ins icons are rendered based on manifest urls

Current behavior

Add-in icons are rendering the default image

Steps to reproduce

No special steps required

Link to live example(s)

Screenshot 2024-05-13 at 8 55 37 PM
Screenshot 2024-05-13 at 8 54 12 PM

Provide additional details

  • This issue affects default Microsoft authored add-ins as well.

Context

Useful logs

  • Console errors
  • Screenshots
  • Test file (if only happens on a particular file)

Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label May 14, 2024
@exextoc exextoc added Needs: attention 👋 Waiting on Microsoft to provide feedback Area: Outlook Issue related to Outlook add-ins and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels May 14, 2024
@exextoc exextoc self-assigned this May 14, 2024
@Adrian-MSFT
Copy link

Hi @bchen-hs-eng. I'm unable to repro this. Does this also happen after clearing the WEF cache?
https://learn.microsoft.com/en-us/office/dev/add-ins/testing/clear-cache#manually

@bchen-hs-eng
Copy link
Author

Hi @Adrian-MSFT Thanks for taking a look at this issue. Clearing the cache restored some of the add-in icons but not all.

We have end users of our add-in reporting this as well, and this occurred after we updated our add-in icons in the manifest. Since this did not happen to all our users, we can assume the icon asset urls are correctly set in the manifest.

Is there a way to clear asset cache automatically when the add-in manifest is updated?

@jrgilman
Copy link

@Adrian-MSFT we are having a similar issue with our manifest and are unsure what to do - it's preventing us from submitting to Microsoft for the add-in store. The issue is in some places it shows the icon, and in others it doesn't even try on desktop:

Screenshot 2024-09-10 115205

If I manually upload the add-in for use in Excel Online, it does work during testing:

image

@Adrian-MSFT
Copy link

@bchen-hs-eng
Thanks for reporting this issue regarding the default icon showing. It is on our backlog. We unfortunately have no timelines to share at this point

Internal tracking id: Office: 9340791

@Adrian-MSFT
Copy link

@jrgilman
Can you confirm that the icons in the manifest are supported file formats? https://learn.microsoft.com/en-us/javascript/api/manifest/image?view=common-js-preview

If they are supported extensions, it will be triaged under the same backlog item mentioned above.

@Adrian-MSFT Adrian-MSFT removed the Needs: attention 👋 Waiting on Microsoft to provide feedback label Sep 11, 2024
@Adrian-MSFT Adrian-MSFT added the Needs: author feedback Waiting for author (creator) of Issue to provide more info label Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: no recent activity Issue or PR is stale (no recent activity) label Oct 7, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

Copy link
Contributor

This issue has been closed due to inactivity. Please comment if you still need assistance and we'll re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Outlook Issue related to Outlook add-ins Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: no recent activity Issue or PR is stale (no recent activity)
Projects
None yet
Development

No branches or pull requests

4 participants