Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Office dialog with ESC while Iframe element has focus leads to bug #9

Closed
michahell opened this issue Aug 24, 2017 · 7 comments
Assignees
Labels
Area: add-in UI Issue related to UI features such as Fabric, dialogs, add-in commands, etc. Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: no recent activity Issue or PR is stale (no recent activity) Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs

Comments

@michahell
Copy link

michahell commented Aug 24, 2017

Exactly as title says: when you hit escape while focusing on an element in the dialog Iframe (say, an input or select) then dialog closes. The dialog can not be opened again.

Expected Behavior

The dialog closes, ánd emits an event with error 12006 (dialog closed by user).

Current Behavior

The dialog closes, and does not emit anything. on top of that, reopening the same dialog shows no dialog.
screenshot 2018-12-05 at 15 16 37

@sumurthy sumurthy added Area: add-in UI Issue related to UI features such as Fabric, dialogs, add-in commands, etc. Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs labels Nov 15, 2017
@ATrogolo
Copy link

Has this issue been fixed?
On Excel (Version: 1803 and Build: 9126.2295) if I open a dialog, press ESC and then trying to reopen the same dialog, it opens correctly.

@michahell
Copy link
Author

Just checked. Yeap, absolutely. And completely ignored by MSFT.

screenshot 2018-12-05 at 15 16 37

@michahell
Copy link
Author

michahell commented Dec 5, 2018

update: there is an error event being sent, code: 12007.
But re-opening is still not possible... see screenshot above. So this is still a bug.

@kbrandl
Copy link
Contributor

kbrandl commented Dec 5, 2018

@michahell sorry to hear that you've having trouble with this, and apologies for the delayed response on this issue.

@JuaneloJuanelo are you able to provide any input on this issue?

@lliu113
Copy link

lliu113 commented Jan 9, 2020

@michahell so sorry for getting back to you so late. I tried to repro this in Word (Version 2001, Build 12428.20000) and I was able to successfully reopen the dialog after closing with ESC. Are you still seeing this issue?

Repro steps (I tried with the DocuSign add-in):

  • Launch DocuSign
  • Click "Log In". Dialog launches.
  • Click ESC. Dialog closes
  • Click "Log In". Dialog successfully reopens.

@lliu113 lliu113 added the Needs: author feedback Waiting for author (creator) of Issue to provide more info label Jan 9, 2020
@ghost ghost added the Status: no recent activity Issue or PR is stale (no recent activity) label Jan 13, 2020
@ghost
Copy link

ghost commented Jan 13, 2020

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

@ghost
Copy link

ghost commented Jan 16, 2020

This issue has been closed due to inactivity. Please comment if you still need assistance and we'll re-open the issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: add-in UI Issue related to UI features such as Fabric, dialogs, add-in commands, etc. Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: no recent activity Issue or PR is stale (no recent activity) Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs
Projects
None yet
Development

No branches or pull requests

7 participants