Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
With the current questions and issues around threading, I had a look at #2299. It seems there was a problem with data races when requesting eval via UCI while a search was already running. To fix this an extra thread uithread was created, presumably to avoid an overlap with Threads.main() that was causing problems. Making this eval request seems to be outside the scope of UCI, and @vondele also reports that the data race is not even fixed reliably by this change. I suggest we simplify the threading here by removing this uithread and adding a comment signaling that user should not request eval when a search is already running. Closes #2310 No functional change.
- Loading branch information