Skip to content

Commit

Permalink
Revert "Simplify Away Quadruple Extensions"
Browse files Browse the repository at this point in the history
This reverts commit 4edd1a3

The unusual result of (combined) +12.0 +- 3.7 in the 2 VVLTC simplification SPRTs ran was the result of base having only 64MB of hash instead of 512MB (Asymmetric hash).
Vizvezdenec was the one to notice this.

closes #5265

bench 1404295

Co-Authored-By: Michael Chaly <26898827+Vizvezdenec@users.noreply.github.com>
  • Loading branch information
2 people authored and vondele committed May 19, 2024
1 parent 99f1bac commit 2d32581
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/search.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1053,9 +1053,11 @@ Value Search::Worker::search(
int doubleMargin = 298 * PvNode - 209 * !ttCapture;
int tripleMargin =
117 + 252 * PvNode - 270 * !ttCapture + 111 * (ss->ttPv || !ttCapture);
int quadMargin = 471 + 343 * PvNode - 281 * !ttCapture + 217 * ss->ttPv;

extension = 1 + (value < singularBeta - doubleMargin)
+ (value < singularBeta - tripleMargin);
+ (value < singularBeta - tripleMargin)
+ (value < singularBeta - quadMargin);

depth += ((!PvNode) && (depth < 15));
}
Expand Down

1 comment on commit 2d32581

@Lesterson74
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for your excellent work.
Is it possible that this works ok? I mean, can someone test it again please (I suspect it is better for long TimeControl test)? I think it could be an improve nonetheless.

Please sign in to comment.