Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The needed Windows API for processor groups could be missed from old Windows versions, so instead of calling them directly (forcing the linker to resolve the calls at compile time), try to load them at runtime. To do this we need first to define the corresponding function pointers. Also don't interfere with running fishtest on numa hardware with Windows. Avoid all stockfish one-threaded processes will run on the same node No functional change.
- Loading branch information
Showing
1 changed file
with
37 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ec626d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a curious question because I don't fully understand the code... Will this behave correctly in cases where we run multiple instances of a multi threaded test on a single NUMA Machine? For example 3 instances of a 7 threaded test get scheduled on a 24 threaded NUMA machine?
2ec626d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2ec626d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks for explaining. I don't care about speculative setups either. I was only concerned about real scenarios on fishtest.