Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove skipQuiets variable in search()
This is a functional simplification. The moveCountPruning variable and the skipQuiets variable are similar enough in function that they can be combined. This removes the skipQuiets variable in search. STC LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 23278 W: 5210 L: 5091 D: 12977 http://tests.stockfishchess.org/tests/view/5c65dc490ebc5925cffc12e9 LTC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 77107 W: 12792 L: 12761 D: 51554 http://tests.stockfishchess.org/tests/view/5c65e4360ebc5925cffc1490 Closes #2011 bench 3640330
- Loading branch information
76d2f5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snicolet @mcostalba @protonspring There is a really nasty side effect of this patch.
Take a look at bench position 38 (default bench):
It starts with a mate in 3 at depth 4, then mate in 4, and finally with the correct mate in 5. This is really weird!
Finding a longer mate and then subsequently settle down to the shortest mate, makes sense. But the other way round like this? Do we really want this?
76d2f5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clearly a new bug which was introduced with this "simplification". Engines should not report an incorrect "shorter" mate that is shorter than the actual shortest mate line. There was no Elo gain with this patch, it was possibly regressive and it introduces a very undesirable artifact which should not be tolerated. (Just my $.02, other may feel differently) .
Seems to be more prevalent with shorter mates I found two more quite easily ( out of 20 or so mates).
This mate-in-4 is reported as mate-in-3 initially.
3q1rk1/4bp1p/1n2P2Q/3p1p2/6r1/Pp2R2N/1B4PP/7K w - -; wac 283
This mate-in-5 is reported as a mate in 4 initially:
r4rk1/4Rppp/p1P5/1p6/3P1n2/1BP2b2/PP3PpP/RN4K1 w - -
76d2f5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened an issue #2019, please follow on there.