Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Now that c++11 branch has been merged in master, disable unconditionally the spinlocks and use mutex instead. This will allow to run fishtest even on HT machines withouth changes. In the future we will reintorduce spinlocks, once we will have took care of fishtest. No functional change.
- Loading branch information
Showing
2 changed files
with
1 addition
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb2111f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to revert spinlocks. There is a fix, proposed by Ronald de Man, that requires no distinction between HT and non HT. Simply add
_mm_pause()
from<immintrin.h>
:Edit: I've opened a pull request, with the fix and test results.