eval command breaks after AccumulatorRefreshTable merged

[PikaCat-OuO]

Describe the issue

The code does not call caches.clear(networks) when running trace. Result in the wrong result for command eval.

Stockfish/src/evaluate.cpp

Lines 100 to 105 in 49ef4c9

	std::string Eval::trace(Position& pos, const Eval::NNUE::Networks& networks) {
	auto caches = std::make_unique<Eval::NNUE::AccumulatorCaches>();
	if (pos.checkers())
	return "Final evaluation: none (in check)";

Expected behavior

output the correct result with command eval

Steps to reproduce

eval

before 49ef4c9:

Stockfish dev-20240422-c2615e30 by the Stockfish developers (see AUTHORS file)
eval
info string NNUE evaluation using nn-ae6a388e4a1a.nnue
info string NNUE evaluation using nn-baff1ede1f90.nnue


 NNUE derived piece values:
+-------+-------+-------+-------+-------+-------+-------+-------+
|   r   |   n   |   b   |   q   |   k   |   b   |   n   |   r   |
| -6.44 | -4.93 | -5.55 | -11.7 |       | -5.48 | -5.05 | -6.64 |
+-------+-------+-------+-------+-------+-------+-------+-------+
|   p   |   p   |   p   |   p   |   p   |   p   |   p   |   p   |
| -0.72 | -1.40 | -1.44 | -1.64 | -1.61 | -1.78 | -1.69 | -0.73 |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|   P   |   P   |   P   |   P   |   P   |   P   |   P   |   P   |
| +0.47 | +1.04 | +1.11 | +1.31 | +1.29 | +1.41 | +1.26 | +0.36 |
+-------+-------+-------+-------+-------+-------+-------+-------+
|   R   |   N   |   B   |   Q   |   K   |   B   |   N   |   R   |
| +6.39 | +4.45 | +5.17 | +9.56 |       | +4.87 | +4.61 | +6.52 |
+-------+-------+-------+-------+-------+-------+-------+-------+

 NNUE network contributions (White to move)
+------------+------------+------------+------------+
|   Bucket   |  Material  | Positional |   Total    |
|            |   (PSQT)   |  (Layers)  |            |
+------------+------------+------------+------------+
|  0         |     0.00   |  -  1.55   |  -  1.55   |
|  1         |     0.00   |  +  0.68   |  +  0.68   |
|  2         |     0.00   |  +  0.29   |  +  0.29   |
|  3         |     0.00   |  +  0.29   |  +  0.29   |
|  4         |     0.00   |  +  0.16   |  +  0.16   |
|  5         |     0.00   |  +  0.31   |  +  0.31   |
|  6         |     0.00   |  +  0.12   |  +  0.12   |
|  7         |     0.00   |  +  0.12   |  +  0.12   | <-- this bucket is used
+------------+------------+------------+------------+

NNUE evaluation        +0.12 (white side)
Final evaluation       +0.13 (white side) [with scaled NNUE, ...]

after:

Stockfish dev-20240424-49ef4c93 by the Stockfish developers (see AUTHORS file)
eval
info string NNUE evaluation using nn-ae6a388e4a1a.nnue
info string NNUE evaluation using nn-baff1ede1f90.nnue


 NNUE derived piece values:
+-------+-------+-------+-------+-------+-------+-------+-------+
|   r   |   n   |   b   |   q   |   k   |   b   |   n   |   r   |
| -5.04 | -4.21 | -4.66 | -10.3 |       | -5.07 | -4.15 | -4.86 |
+-------+-------+-------+-------+-------+-------+-------+-------+
|   p   |   p   |   p   |   p   |   p   |   p   |   p   |   p   |
| +0.08 | -0.15 | -0.27 | -0.07 | -0.22 | -1.40 | -0.70 | -0.18 |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|       |       |       |       |       |       |       |       |
|       |       |       |       |       |       |       |       |
+-------+-------+-------+-------+-------+-------+-------+-------+
|   P   |   P   |   P   |   P   |   P   |   P   |   P   |   P   |
| +0.33 | +0.29 | +0.10 | +0.14 | +0.49 | +0.74 | +0.50 | +0.22 |
+-------+-------+-------+-------+-------+-------+-------+-------+
|   R   |   N   |   B   |   Q   |   K   |   B   |   N   |   R   |
| +4.46 | +4.06 | +4.59 | +6.79 |       | +4.51 | +4.26 | +4.48 |
+-------+-------+-------+-------+-------+-------+-------+-------+

 NNUE network contributions (White to move)
+------------+------------+------------+------------+
|   Bucket   |  Material  | Positional |   Total    |
|            |   (PSQT)   |  (Layers)  |            |
+------------+------------+------------+------------+
|  0         |     0.00   |  -  8.75   |  -  8.75   |
|  1         |     0.00   |  +  0.22   |  +  0.22   |
|  2         |     0.00   |  -  0.93   |  -  0.93   |
|  3         |     0.00   |  -  0.09   |  -  0.09   |
|  4         |     0.00   |  -  2.28   |  -  2.28   |
|  5         |     0.00   |  +  1.20   |  +  1.20   |
|  6         |     0.00   |  -  0.61   |  -  0.61   |
|  7         |     0.00   |  -  0.11   |  -  0.11   | <-- this bucket is used
+------------+------------+------------+------------+

NNUE evaluation        -0.11 (white side)
Final evaluation       -0.12 (white side) [with scaled NNUE, ...]

Anything else?

No response

Operating system

All

Stockfish version

49ef4c9