Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify logic for history based pruning #1066

Closed
wants to merge 3 commits into from

Conversation

vondele
Copy link
Member

@vondele vondele commented Apr 14, 2017

Use -1 one as a sentinel value, which allows for simplifying the logic for pruning later.

STC
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 34255 W: 6292 L: 6194 D: 21769

LTC
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 89914 W: 11769 L: 11739 D: 66406

Bench: 5767899

@zamar
Copy link

zamar commented Apr 17, 2017

Problems with this patch:

  1. std::memset(-1, ...) is undefined behaviour based on standard.

  2. If anyone will try to tweak VALUE_ZERO downwards (which some will do sooner or later), they will be break the implementation.

@vondele
Copy link
Member Author

vondele commented Apr 17, 2017

@zamar this would be a version that addresses both concerns. What do you think ?

Use -1 one as a sentinel value, which allows for simplifying the logic for pruning later.

STC
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 34255 W: 6292 L: 6194 D: 21769

LTC
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 89914 W: 11769 L: 11739 D: 66406

Bench: 5767899
Rebased, corrected fill.

Bench: 5994607
@zamar
Copy link

zamar commented Apr 17, 2017

That looks fine for me. However you should add a comment about the meaning of cmThreshold (search.cpp, line 78)

@zamar zamar closed this in ced2924 Apr 20, 2017
MichaelB7 pushed a commit to MichaelB7/Stockfish that referenced this pull request Apr 23, 2020
@vondele vondele mentioned this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants