Some small changes #1524
Closed
Some small changes #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) Better code reuse and generalization in position.h (inspired by make_bitboard(...)) 3) Fix MSVC warning: search.h(85): warning C4244: '=': conversion from 'TimePoint' to 'int', possible loss of data No functional change. Same speed. bench: 5568461
|
Number 2 is not needed. I think it is a good guidleline to implement just what is needed, this is a rule I followed (maybe too strict) in the past and it prevented me to add a lot of useless boilerplate code. |
|
@mcostalba I agree about only what is needed but want to point out that in this case the bit of extra general functionality is only a bonus side effect. The goal was to reduce code which it does. |
|
@mstembera I have merged the non-controversial parts of the pull request in 76f9cd4, thanks! The (b) part could be an independent commit -- or a part of a larger commit if you |
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
Apr 1, 2018
1) Use make_bitboard() in Bitboards::init() 2) Fix MSVC warning: search.h(85): warning C4244: '=': conversion from 'TimePoint' to 'int', possible loss of data. Closes official-stockfish/Stockfish#1524 No functional change.
goodkov
pushed a commit
to goodkov/Stockfish
that referenced
this pull request
Jul 21, 2018
1) Use make_bitboard() in Bitboards::init() 2) Fix MSVC warning: search.h(85): warning C4244: '=': conversion from 'TimePoint' to 'int', possible loss of data. Closes official-stockfish#1524 No functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use make_bitboard() in Bitboards::init()
Remove code and improve reuse in position.h. Also more general since pieces() can now be called
with more than just 2 arguments.
(inspired by make_bitboard(...))
Fix MSVC warning:
search.h(85): warning C4244: '=': conversion from 'TimePoint' to 'int', possible loss of data
No functional change. Same speed.
bench: 5568461