Remove template W param. #1557
Closed
Remove template W param. #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different W template parameters for the different statEntries are not needed, consistently use 32. Passed STC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 21683 W: 4545 L: 4424 D: 12714 http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59 Passed LTC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 110391 W: 16551 L: 16562 D: 77278 http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61 Bench: 5120532
as a follow up, it is logical to remove W completely by absorbing it in the bonus calculation. verified at STC: LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 40091 W: 8222 L: 8136 D: 23733 http://tests.stockfishchess.org/tests/view/5ad910050ebc5902a3efed00 No functional change.
|
Added one further non-functional commit that removes W completely. |
as suggested and tested by @mstembera. passed STC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 27597 W: 5591 L: 5481 D: 16525 http://tests.stockfishchess.org/tests/view/5ad9981a0ebc5902a3efed77 passed LTC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 90198 W: 13505 L: 13486 D: 63207 http://tests.stockfishchess.org/tests/view/5ad9ccf00ebc5902a3efedc8 Bench: 5245265
|
Merged via a64d524, thanks! Note: I have not merged the third commit ("Further get rid of a division") because the tests were not against the first two commits of the pull request. |
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
Apr 24, 2018
Different W template parameters for the different statEntries are not needed, simplify by consistently using 32. Passed STC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 21683 W: 4545 L: 4424 D: 12714 http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59 Passed LTC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 110391 W: 16551 L: 16562 D: 77278 http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61 Closes official-stockfish/Stockfish#1557 Bench: 5120532
goodkov
pushed a commit
to goodkov/Stockfish
that referenced
this pull request
Jul 21, 2018
Different W template parameters for the different statEntries are not needed, simplify by consistently using 32. Passed STC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 21683 W: 4545 L: 4424 D: 12714 http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59 Passed LTC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 110391 W: 16551 L: 16562 D: 77278 http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61 Closes official-stockfish#1557 Bench: 5120532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different W template parameters for the different statEntries are not needed,
consistently use 32.
Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 21683 W: 4545 L: 4424 D: 12714
http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59
Passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 110391 W: 16551 L: 16562 D: 77278
http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61
Bench: 5120532