New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove template W param. #1557

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@vondele

vondele commented Apr 19, 2018

Different W template parameters for the different statEntries are not needed,
consistently use 32.

Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 21683 W: 4545 L: 4424 D: 12714
http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59

Passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 110391 W: 16551 L: 16562 D: 77278
http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61

Bench: 5120532

vondele added some commits Apr 18, 2018

Remove template W param.
Different W template parameters for the different statEntries are not needed,
consistently use 32.

Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 21683 W: 4545 L: 4424 D: 12714
http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59

Passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 110391 W: 16551 L: 16562 D: 77278
http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61

Bench: 5120532
Remove W completely.
as a follow up, it is logical to remove W completely by absorbing it in the bonus calculation.

verified at STC:
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 40091 W: 8222 L: 8136 D: 23733
http://tests.stockfishchess.org/tests/view/5ad910050ebc5902a3efed00

No functional change.
@vondele

This comment has been minimized.

Show comment
Hide comment
@vondele

vondele Apr 20, 2018

Added one further non-functional commit that removes W completely.

vondele commented Apr 20, 2018

Added one further non-functional commit that removes W completely.

Further get rid of a division.
as suggested and tested by @mstembera.

passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 27597 W: 5591 L: 5481 D: 16525
http://tests.stockfishchess.org/tests/view/5ad9981a0ebc5902a3efed77

passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 90198 W: 13505 L: 13486 D: 63207
http://tests.stockfishchess.org/tests/view/5ad9ccf00ebc5902a3efedc8

Bench: 5245265

@snicolet snicolet closed this in a64d524 Apr 23, 2018

@snicolet

This comment has been minimized.

Show comment
Hide comment
@snicolet

snicolet Apr 23, 2018

Merged via a64d524, thanks!

Note: I have not merged the third commit ("Further get rid of a division") because the tests were not against the first two commits of the pull request.

snicolet commented Apr 23, 2018

Merged via a64d524, thanks!

Note: I have not merged the third commit ("Further get rid of a division") because the tests were not against the first two commits of the pull request.

joergoster added a commit to joergoster/Stockfish that referenced this pull request Apr 24, 2018

Remove template W param
Different W template parameters for the different statEntries are
not needed, simplify by consistently using 32.

Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 21683 W: 4545 L: 4424 D: 12714
http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59

Passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 110391 W: 16551 L: 16562 D: 77278
http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61

Closes official-stockfish#1557

Bench: 5120532

goodkov added a commit to goodkov/Stockfish that referenced this pull request Jul 21, 2018

Remove template W param
Different W template parameters for the different statEntries are
not needed, simplify by consistently using 32.

Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 21683 W: 4545 L: 4424 D: 12714
http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59

Passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 110391 W: 16551 L: 16562 D: 77278
http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61

Closes official-stockfish#1557

Bench: 5120532

mstembera referenced this pull request in snicolet/Stockfish Aug 21, 2018

aggg63 added a commit to aggg63/Stockfish that referenced this pull request Aug 22, 2018

Remove template W param
Different W template parameters for the different statEntries are
not needed, simplify by consistently using 32.

Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 21683 W: 4545 L: 4424 D: 12714
http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59

Passed LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 110391 W: 16551 L: 16562 D: 77278
http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61

Closes official-stockfish#1557

Bench: 5120532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment