Correctly prevent recursive verification in nmp. #1610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define Color us and use this instead of pos.side_to_move() and nmp_odd. The latter allows to clarify the nmp verification criterion. Tested for no regression: LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 76713 W: 15303 L: 15284 D: 46126 http://tests.stockfishchess.org/tests/view/5b046a0d0ebc5914abc12971 No functional change.
|
seems like appveyor CI is failing randomly again. Closing and reopening this PR to try and trigger retesting. |
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 changing at high depth, bench: 4484288
|
Approved |
|
Merged via beaadd6, thanks! |
goodkov
pushed a commit
to goodkov/Stockfish
that referenced
this pull request
Jul 21, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
CounterPly
pushed a commit
to CounterPly/Stockfish
that referenced
this pull request
Jul 24, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
CounterPly
pushed a commit
to CounterPly/Stockfish
that referenced
this pull request
Jul 30, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
CounterPly
pushed a commit
to CounterPly/Stockfish
that referenced
this pull request
Jul 30, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
CounterPly
pushed a commit
to CounterPly/Stockfish
that referenced
this pull request
Sep 10, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
CounterPly
pushed a commit
to CounterPly/Stockfish
that referenced
this pull request
Oct 16, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
CounterPly
pushed a commit
to CounterPly/Stockfish
that referenced
this pull request
Oct 16, 2018
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely). This patch is tested as a bug fix, based on and tested against PR official-stockfish#1609 . passed STC: http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5 LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 7875 W: 1669 L: 1523 D: 4683 passed LTC: http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd LLR: 3.00 (-2.94,2.94) [-3.00,1.00] Total: 24048 W: 3525 L: 3407 D: 17116 Bench changes at high depth. Closes official-stockfish#1610 and official-stockfish#1609 Bench: 4484288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @pb00068, the condition to prevent recursive verification was not completely correct. This patch corrects that condition, and adds an assert. In the current implementation, recursive verification needs to be avoided in order not to break the verification of the move closer to the root (i.e. to not set thisThread->nmp_min_ply to zero prematurely).
This patch is tested as a bug fix, based on and tested against PR #1609 .
passed STC:
http://tests.stockfishchess.org/tests/view/5b050f170ebc5914abc129c5
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 7875 W: 1669 L: 1523 D: 4683
passed LTC:
http://tests.stockfishchess.org/tests/view/5b0513970ebc5914abc129cd
LLR: 3.00 (-2.94,2.94) [-3.00,1.00]
Total: 24048 W: 3525 L: 3407 D: 17116
changing at high depth, bench: 4484288