Two simplifications in passed pawns evaluation #1769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You say that neither can be removed independently, but you had some greens here But indeed your new result is stronger, |
|
Yes, but both of those tests, although passed, indicated some elo loss,
whereas this version does not.
…On Fri, Sep 14, 2018, 5:45 PM Rocky640 ***@***.***> wrote:
You say that neither can be removed independently, but you had some greens
here
STC http://tests.stockfishchess.org/tests/view/5b92910d0ebc592cf2753bf6
LTC http://tests.stockfishchess.org/tests/view/5b92acae0ebc592cf2753ebb
But indeed your new result is stronger,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1769 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcVnSJ7lSeBbZBCedGWEPpZBq-DZH9eQks5ubD98gaJpZM4WqDgB>
.
|
|
This is a superb simplification, lets submit it? Is the failed travis ci a problem? |
|
Merged via 13d06ed, congrats! |
|
Just an interim commit waiting for the return of Stefan Geschwentner. I hope he is well! |
lantonov
pushed a commit
to lantonov/Stockfish
that referenced
this pull request
Sep 30, 2018
These two simplifications appear to be affecting and/or offsetting each other. Neither can be removed independently, but in combination they pass -3,1. STC LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 36391 W: 7888 L: 7795 D: 20708 http://tests.stockfishchess.org/tests/view/5b9bce410ebc592cf275f1b2 LTC LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 19513 W: 3237 L: 3114 D: 13162 http://tests.stockfishchess.org/tests/view/5b9c0edf0ebc592cf275f80e Closes official-stockfish#1769 bench 4059356
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Oct 18, 2018
These two simplifications appear to be affecting and/or offsetting each other. Neither can be removed independently, but in combination they pass -3,1. STC LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 36391 W: 7888 L: 7795 D: 20708 http://tests.stockfishchess.org/tests/view/5b9bce410ebc592cf275f1b2 LTC LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 19513 W: 3237 L: 3114 D: 13162 http://tests.stockfishchess.org/tests/view/5b9c0edf0ebc592cf275f80e Closes official-stockfish#1769 bench 4059356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two simplifications appear to be affecting and/or offsetting each other. Neither can be removed independently, but in combination they pass -3,1.
STC
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 36391 W: 7888 L: 7795 D: 20708
http://tests.stockfishchess.org/tests/view/5b9bce410ebc592cf275f1b2
LTC
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 19513 W: 3237 L: 3114 D: 13162
http://tests.stockfishchess.org/tests/view/5b9c0edf0ebc592cf275f80e
bench 4722355