Use emplace_back instead of push_back #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok for me. Please format the commit message as following: Use emplace_back in TB code No functional change. |
|
@mcostalba done |
|
@UniQP |
No functional change.
|
@snicolet I rebased the branch to the current master and executed bench with and without the PR: I also filtered the tbhits from both logs: The number of tbhits are equal in both logs. |
|
@UniQP Thanks, I will merge it! |
snicolet
pushed a commit
that referenced
this pull request
Nov 29, 2018
The patch was tested for correctness by running bench with and without the change against current master, and the tablebase hit numbers were found to be identical in both cases. See the pull request comments for details: #1826 No functional change.
|
Merged via 340e9ea, thanks! |
phlopsi
pushed a commit
to phlopsi/Stockfish
that referenced
this pull request
Dec 23, 2018
The patch was tested for correctness by running bench with and without the change against current master, and the tablebase hit numbers were found to be identical in both cases. See the pull request comments for details: official-stockfish#1826 No functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.