No influence on unsafeSquares of passers by pieces #2248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove their pieces from influencing 'unsafeSquares' in passer evaluation. STC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 36421 W: 8170 L: 8078 D: 20173 http://tests.stockfishchess.org/tests/view/5d22fc8e0ebc5925cf0cb26e LTC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18927 W: 3253 L: 3129 D: 12545 http://tests.stockfishchess.org/tests/view/5d26e2b20ebc5925cf0d3218 Bench: 3748938
|
Having second thoughts: It was there and removing it gained elo; nothing more to say. |
|
"second thoughts"? How do you mean? Seems like a good change to me.
|
|
@Lolligerhans I agree with @xoto10, this looks like an excellent patch. My only concern is that your name should be added to the author list :) It's in the |
|
Approved |
Closed
|
Merged via fd96cba, congrats :-) |
|
@Lolligerhans |
|
@snicolet No, "Lolligerhans" is a made up nick. Will update "trivial cleanups". |
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Jul 31, 2019
Remove their pieces from influencing 'unsafeSquares' in passer evaluation. STC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 36421 W: 8170 L: 8078 D: 20173 http://tests.stockfishchess.org/tests/view/5d22fc8e0ebc5925cf0cb26e LTC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18927 W: 3253 L: 3129 D: 12545 http://tests.stockfishchess.org/tests/view/5d26e2b20ebc5925cf0d3218 Closes official-stockfish#2248 Bench: 3285659
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Aug 1, 2019
Remove their pieces from influencing 'unsafeSquares' in passer evaluation. STC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 36421 W: 8170 L: 8078 D: 20173 http://tests.stockfishchess.org/tests/view/5d22fc8e0ebc5925cf0cb26e LTC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18927 W: 3253 L: 3129 D: 12545 http://tests.stockfishchess.org/tests/view/5d26e2b20ebc5925cf0d3218 Closes official-stockfish#2248 Bench: 3285659
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Aug 29, 2019
Remove their pieces from influencing 'unsafeSquares' in passer evaluation. STC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 36421 W: 8170 L: 8078 D: 20173 http://tests.stockfishchess.org/tests/view/5d22fc8e0ebc5925cf0cb26e LTC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18927 W: 3253 L: 3129 D: 12545 http://tests.stockfishchess.org/tests/view/5d26e2b20ebc5925cf0d3218 Closes official-stockfish#2248 Bench: 3285659
pb00068
pushed a commit
to pb00068/Stockfish
that referenced
this pull request
Sep 10, 2019
Remove their pieces from influencing 'unsafeSquares' in passer evaluation. STC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 36421 W: 8170 L: 8078 D: 20173 http://tests.stockfishchess.org/tests/view/5d22fc8e0ebc5925cf0cb26e LTC LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18927 W: 3253 L: 3129 D: 12545 http://tests.stockfishchess.org/tests/view/5d26e2b20ebc5925cf0d3218 Closes official-stockfish#2248 Bench: 3285659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove their pieces from influencing 'unsafeSquares' in passer
evaluation.
STC
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 36421 W: 8170 L: 8078 D: 20173
http://tests.stockfishchess.org/tests/view/5d22fc8e0ebc5925cf0cb26e
LTC
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 18927 W: 3253 L: 3129 D: 12545
http://tests.stockfishchess.org/tests/view/5d26e2b20ebc5925cf0d3218
Bench: 3748938