Passed file cleanup #2251
Closed
Passed file cleanup #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged via 9dc57b6, congrats :-) |
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Jul 31, 2019
Protonspring had a successful functional simplification that removes the PassedFile array using a simple linear equation. Merge the additive term S(5, 10) of protonspring passed file simplification (pull request official-stockfish#2250) into the PassedRank array. This harmless change has a different bench because the candidate passer evaluation will always get less compared to official-stockfish#2250, as we apply bonus = bonus /2. Tested as a non-regression against official-stockfish#2250 Passed STC http://tests.stockfishchess.org/tests/view/5d33427e0ebc5925cf0e6fa2 LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 81459 W: 18174 L: 18171 D: 45114 Passed LTC http://tests.stockfishchess.org/tests/view/5d335c8d0ebc5925cf0e731e LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18525 W: 3176 L: 3052 D: 12297 Closes official-stockfish#2250 Closes official-stockfish#2251 Bench: 3859856
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Aug 1, 2019
Protonspring had a successful functional simplification that removes the PassedFile array using a simple linear equation. Merge the additive term S(5, 10) of protonspring passed file simplification (pull request official-stockfish#2250) into the PassedRank array. This harmless change has a different bench because the candidate passer evaluation will always get less compared to official-stockfish#2250, as we apply bonus = bonus /2. Tested as a non-regression against official-stockfish#2250 Passed STC http://tests.stockfishchess.org/tests/view/5d33427e0ebc5925cf0e6fa2 LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 81459 W: 18174 L: 18171 D: 45114 Passed LTC http://tests.stockfishchess.org/tests/view/5d335c8d0ebc5925cf0e731e LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18525 W: 3176 L: 3052 D: 12297 Closes official-stockfish#2250 Closes official-stockfish#2251 Bench: 3859856
mstembera
pushed a commit
to mstembera/Stockfish
that referenced
this pull request
Aug 29, 2019
Protonspring had a successful functional simplification that removes the PassedFile array using a simple linear equation. Merge the additive term S(5, 10) of protonspring passed file simplification (pull request official-stockfish#2250) into the PassedRank array. This harmless change has a different bench because the candidate passer evaluation will always get less compared to official-stockfish#2250, as we apply bonus = bonus /2. Tested as a non-regression against official-stockfish#2250 Passed STC http://tests.stockfishchess.org/tests/view/5d33427e0ebc5925cf0e6fa2 LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 81459 W: 18174 L: 18171 D: 45114 Passed LTC http://tests.stockfishchess.org/tests/view/5d335c8d0ebc5925cf0e731e LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18525 W: 3176 L: 3052 D: 12297 Closes official-stockfish#2250 Closes official-stockfish#2251 Bench: 3859856
pb00068
pushed a commit
to pb00068/Stockfish
that referenced
this pull request
Sep 10, 2019
Protonspring had a successful functional simplification that removes the PassedFile array using a simple linear equation. Merge the additive term S(5, 10) of protonspring passed file simplification (pull request official-stockfish#2250) into the PassedRank array. This harmless change has a different bench because the candidate passer evaluation will always get less compared to official-stockfish#2250, as we apply bonus = bonus /2. Tested as a non-regression against official-stockfish#2250 Passed STC http://tests.stockfishchess.org/tests/view/5d33427e0ebc5925cf0e6fa2 LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 81459 W: 18174 L: 18171 D: 45114 Passed LTC http://tests.stockfishchess.org/tests/view/5d335c8d0ebc5925cf0e731e LLR: 2.95 (-2.94,2.94) [-3.00,1.00] Total: 18525 W: 3176 L: 3052 D: 12297 Closes official-stockfish#2250 Closes official-stockfish#2251 Bench: 3859856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the additive term S(5, 10) of #2250 into the PassedRank array.
This harmless change have a different bench because, the candidate passer evaluation
(those for which we apply bonus = bonus /2;)
will always get S(5, 10)/2 less compared to # 2250
Tested as a non-regression against #2250
Passed STC
http://tests.stockfishchess.org/tests/view/5d33427e0ebc5925cf0e6fa2
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 81459 W: 18174 L: 18171 D: 45114
Passed LTC
http://tests.stockfishchess.org/tests/view/5d335c8d0ebc5925cf0e731e
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 18525 W: 3176 L: 3052 D: 12297