Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged] Prevent "Smarter time management near stop limit" if ponder enabled. #2487

Closed
wants to merge 1 commit into from

Conversation

xoto10
Copy link
Contributor

@xoto10 xoto10 commented Jan 13, 2020

The recent PR #2482 has a flaw in that it stops searches getting deeper during pondering. This change fixes this by preventing iterations from being searched again if pondering is enabled.

CURRENTLY UNTESTED

Bench 4586187

@snicolet
Copy link
Member

Merged via 01dfdb9, thanks!

@snicolet snicolet changed the title Prevent "Smarter time management near stop limit" if ponder enabled. [Merged] Prevent "Smarter time management near stop limit" if ponder enabled. Jan 13, 2020
@xoto10
Copy link
Contributor Author

xoto10 commented Jan 13, 2020

Haha, ok.
I'm running a test just to check no obvious flaws, but the change is straightforward, so it seems reliable. Tests already showing roughly even performance, and that's all we can expect from a small number of games.

@xoto10
Copy link
Contributor Author

xoto10 commented Jan 13, 2020

I ran 2 tests with ponder on:
400 games @ 1+0.07 research3prfix vs master +97 -92 =211
1000 games @ 2+0.1 research3prfix vs master +246 -207 =547

@adentong
Copy link

I think this can be closed now.

@snicolet snicolet closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants