Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit array access in Position #2595

Closed

Conversation

protonspring
Copy link

This is a non-functional code style change that routes all position array accesses to single methods.

This way, we can (and I probably should) add an assert(is_ok(s)) to one method and it will affect all of them. I think this is generally good practice and makes the code easier to read. There is not likely any performance difference.

STC
LLR: 2.94 (-2.94,2.94) {-1.50,0.50}
Total: 37312 W: 7378 L: 7246 D: 22688
Ptnml(0-2): 606, 4280, 8762, 4392, 616
https://tests.stockfishchess.org/tests/view/5e7c0c69e42a5c3b3ca2eb3d

@vondele
Copy link
Member

vondele commented Mar 26, 2020

CI fails for a reason unrelated to the patch, 4men TB can't be downloaded right now.

@vondele vondele closed this in 0b8ce4b Apr 2, 2020
@vondele
Copy link
Member

vondele commented Apr 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants