-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase bonus for multiple safe checks #2636
Increase bonus for multiple safe checks #2636
Conversation
181144a
to
84ee437
Compare
Adjusted the subject line twice. |
84ee437
to
8e009c7
Compare
It may be a good idea to tune 4 specific values instead of using 3/2 of the normal bonus. |
Was |
Add 50% "safe checks" bonus when there are multiple safe checks from the same piece type. LTC LLR: 2.97 (-2.94,2.94) {0.25,1.75} Total: 128184 W: 16491 L: 15954 D: 95739 Ptnml(0-2): 884, 11793, 38267, 12198, 950 https://tests.stockfishchess.org/tests/view/5e97d1b6c9ada107a0370e03 STC LLR: 2.94 (-2.94,2.94) {-0.50,1.50} Total: 19022 W: 3733 L: 3514 D: 11775 Ptnml(0-2): 338, 2103, 4414, 2314, 342 https://tests.stockfishchess.org/tests/view/5e97c377c9ada107a0370ddf Bench: 4962192
8e009c7
to
e78e883
Compare
@ddugovic I also tried doubling (factor 2) if more than one, which failed badly. If you want to try count (which is greater or equal to that) you will probably need to reduce the base bonus significantly. Note the multitude of check- or check-related bonuses which (may) interact with changes: kingAttackersCount, kingAttackersWeight, kingAttacksCount, unsafeChecks, safeChecks. |
@Lolligerhans shud this be tested again on top of Fauzi's parameter changes, just wanted to confirm if the changes in this PR are not related (and | or interact with) to parameter tweaks made in Fauzi's PR? |
@anshulongithub The changes do relate as this increase |
@anshulongithub there is a small overlap indeed, but I have no worry about this. |
Thanks! I agree with @Rocky640 on this. |
There may be more specific ways to increase checking bonuses. This patch is rather generic and probably not optimal.
I use a more concise style than the tests, using
?:
instead ofif
and adding the total bonus instead of multiple smaller parts.I remove blank lines to group computations of check bitboards with their respective bonuses in a paragraph.