Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syzygy dependencies (issue #2660) #2663

Closed
wants to merge 5 commits into from

Conversation

gvreuls
Copy link
Contributor

@gvreuls gvreuls commented May 6, 2020

This fixes the syzygy dependency errors mentioned in issue #2660.

Changes:

  • All .o object files now reside in the src directory itself.
  • Instead of a single .depend file there now is a .dep directory
    containing individual .d dependency files for every generated object
    file.

No functional change.

Edit: removed adding the src directory to the include path because of revert.

Changes:
- All .o object files now reside in the src directory itself.
- Instead of a single .depend file there now is a .dep directory
containing individual .d dependency files for every generated object
file.
- The src directory is added to the include path so source and header
files in subdirectories (like syzygy) can include header files in the
src directory directly (without the "../" prefix).

No functional change.
Writing separate .d dependency files to the .dep directory isn't revered
because generating the dependency files on the fly while compiling the
object file is more efficient (it saves the compiler run to generate the
dependency file).
@gvreuls
Copy link
Contributor Author

gvreuls commented May 8, 2020

I'll close this one because joost prefers xoto's solution #2664

@gvreuls gvreuls closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant