Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a trivially copyable struct for TBTables::Entry instead of a tuple. #2674

Closed

Conversation

Sopel97
Copy link
Member

@Sopel97 Sopel97 commented May 12, 2020

Fixes #2673

@vondele vondele added the to be merged Will be merged shortly label May 13, 2020
@vondele vondele closed this in 86ee4eb May 13, 2020
@vondele
Copy link
Member

vondele commented May 13, 2020

Thanks!

@gvreuls
Copy link
Contributor

gvreuls commented May 15, 2020

Joachim Müller (JojoM) reports on fishcooking that his workers get a compiler error on the use of std::is_trivially_copyable. Perhaps get rid of the static assert on line 417?

@vondele
Copy link
Member

vondele commented May 15, 2020

Okay.... GCC versions < 5 do not support std::is_trivially_copyable from the C++11 standard.
and he's using 4.9, so we might remove it as a workaround.

@Sopel97 Sopel97 deleted the trivially_copyable_entry branch November 14, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc 10.1 warning
3 participants