Wrap all access to LineBB and add assert. #2719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR would be a good occasion to add examples for line_bb() and between_bb(), if only to make obvious the difference between the two functions, and also as a quick reference showing if the extrémal squares are included in between_bb() or not. Something like: For instance, line_bb(c4, f7) returns the bitboard corresponding to the whole diagonal a2-g8. For instance, between_bb(c4, f7) returns the bitboard with the squares d5 and e6. PS: i am away from computer, so double check the examples 🙂 |
|
Will do . . just a few minutes. |
|
Thanks! |
MichaelB7
pushed a commit
to MichaelB7/Stockfish
that referenced
this pull request
Jun 13, 2020
This is a non-functional code style change which provides a safe access handler for LineBB. Also includes an assert in debug mode to verify square correctness. closes official-stockfish#2719 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-functional code style change which provides a safe access handler for LineBB. Also includes an assert in debug mode to verify square correctness. Please let me know if this needs to be tested.