Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert LTO for mingw on windows. #2774

Closed
wants to merge 1 commit into from

Conversation

vondele
Copy link
Member

@vondele vondele commented Jun 27, 2020

LTO with static linking is still only working with the latest versions of gcc,
causing problems for some devs.

fixes #2769

No functional change.

LTO with static linking is still only working with the latest versions of gcc,
causing problems for some devs.

fixes official-stockfish#2769

No functional change.
@stockchess
Copy link

backward step imho, lose good speed gain with lto. suggest have flag to switch lto on with mingw, flag (name mingwtlo?), off by default avoids problems with nonworking mingw users

@vondele
Copy link
Member Author

vondele commented Jun 27, 2020

note that one can always add flags to the build without Makefile modification. You should be able to do:

CXXFLAGS='-flto' make -j ARCH=x86-64-modern build COMP=mingw

does that work for you?

@stockchess
Copy link

works, thx for tip.

@vondele vondele added the to be merged Will be merged shortly label Jun 27, 2020
@vondele vondele closed this in ca41ee6 Jun 27, 2020
@mstembera
Copy link
Contributor

FYI it's possible to check the gcc/mingw version in the makefile.
https://stackoverflow.com/questions/5188267/checking-the-gcc-version-in-a-makefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LTO on windows
3 participants