Denormalize KRKP #2786
Closed
Denormalize KRKP #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for me that's also easier to read, but I'd like the opinion of others here.. |
|
Thanks! |
ddugovic
pushed a commit
to ddugovic/Stockfish
that referenced
this pull request
Jul 7, 2020
a non-functional code style change that denormalizes the KRKP endgame, making it somewhat easier to read. closes official-stockfish#2786 No functional change
noobpwnftw
pushed a commit
to noobpwnftw/Stockfish
that referenced
this pull request
Aug 15, 2020
a non-functional code style change that denormalizes the KRKP endgame, making it somewhat easier to read. closes official-stockfish#2786 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-functional code style change that denormalizes the KRKP endgame. For me, this is a bit easier to read, and it's a little less code.
Here's why it's less code, since it may not be immediately apparent:
relative_square() and relative_rank() are 2 operations, a rank_of() is a single shift, and a pawn_push is a ternary operator.
For the relevant changes, master does 10 operations (4 relative_squares, and two rank_of).
This patch reduces the relevant code to 6 operations (3 relative_ranks) and 2 pawn_pushes.
I don't suspect this needs to be tested, but I'm happy to do it if requested.