Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QueenInfiltration #2910

Closed
wants to merge 2 commits into from
Closed

Remove QueenInfiltration #2910

wants to merge 2 commits into from

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Aug 5, 2020

STC https://tests.stockfishchess.org/tests/view/5f2955b1a5abc164f05e4c85
LLR: 2.96 (-2.94,2.94) {-1.50,0.50}
Total: 29216 W: 5560 L: 5416 D: 18240
Ptnml(0-2): 466, 3329, 6902, 3417, 494

LTC https://tests.stockfishchess.org/tests/view/5f299154a5abc164f05e4ca1
LLR: 2.92 (-2.94,2.94) {-1.50,0.50}
Total: 54144 W: 6635 L: 6594 D: 40915
Ptnml(0-2): 372, 4859, 16536, 4966, 339

bench: 4023423

Remove QueenInfiltration from eval.

@gonzalezjo
Copy link

Major deja vu from this PR.

@AlexandreMasta
Copy link

But why?

This eval was intruduced just a few days ago.

Why do ppl rush in making such removals?

@unaiic
Copy link
Contributor Author

unaiic commented Aug 5, 2020

It was actually introduced more than a month ago, and just as happened to king infiltration, there is nothing wrong with removing it IMO if it passes the tests.

@ddugovic
Copy link

ddugovic commented Aug 5, 2020

The tests pass and I was surprised #2759 passed in the first place (many evaluation terms are gradual but this term is not).

@FauziAkram
Copy link
Contributor

This Bonus works very well the longer the time control is, which means that it scales perfectly well, it would be really a pity to remove it just because it does not scale super well at STC.
I wish we could test it also at VLTC, and I am pretty sure it will never pass the simplification bounds

@ddugovic
Copy link

ddugovic commented Aug 5, 2020

Hm, I wonder if it is possible (after merging this patch) to write a form of it which gradually increases the bonus based upon how safe the queen is.

@gonzalezjo
Copy link

Doesn’t hurt to try it at LTC again. Maybe the last LTC wasn’t a fluke and QI just works better at LTC. I don’t think that’s that likely, though.

@mrobaczyk
Copy link

Seems like it is possible that a "new-term" patch can pass a test and then simplification of that patch passes too, which can go forever.

@ddugovic
Copy link

ddugovic commented Aug 6, 2020

Yes, and ability to go forever is not a bad thing, especially not when other queen evaluation patches are merged.

Perhaps next time this bonus is developed, instead of using a fixed S( -2, 14) it could somehow scale with how many squares the queen is attacking or something like that, so it is less likely to be simplified in the future.

@vondele vondele added the to be merged Will be merged shortly label Aug 7, 2020
@vondele vondele closed this in 7f336dd Aug 7, 2020
@vondele
Copy link
Member

vondele commented Aug 7, 2020

Thanks

@unaiic unaiic deleted the yc2 branch August 9, 2020 14:01
noobpwnftw pushed a commit to noobpwnftw/Stockfish that referenced this pull request Aug 15, 2020
STC https://tests.stockfishchess.org/tests/view/5f2955b1a5abc164f05e4c85
LLR: 2.96 (-2.94,2.94) {-1.50,0.50}
Total: 29216 W: 5560 L: 5416 D: 18240
Ptnml(0-2): 466, 3329, 6902, 3417, 494

LTC https://tests.stockfishchess.org/tests/view/5f299154a5abc164f05e4ca1
LLR: 2.92 (-2.94,2.94) {-1.50,0.50}
Total: 54144 W: 6635 L: 6594 D: 40915
Ptnml(0-2): 372, 4859, 16536, 4966, 339

closes official-stockfish#2910

Bench: 4609008
Dantist pushed a commit to Dantist/Stockfish that referenced this pull request Dec 22, 2020
STC https://tests.stockfishchess.org/tests/view/5f2955b1a5abc164f05e4c85
LLR: 2.96 (-2.94,2.94) {-1.50,0.50}
Total: 29216 W: 5560 L: 5416 D: 18240
Ptnml(0-2): 466, 3329, 6902, 3417, 494

LTC https://tests.stockfishchess.org/tests/view/5f299154a5abc164f05e4ca1
LLR: 2.92 (-2.94,2.94) {-1.50,0.50}
Total: 54144 W: 6635 L: 6594 D: 40915
Ptnml(0-2): 372, 4859, 16536, 4966, 339

closes official-stockfish#2910

Bench: 4609008
BM123499 pushed a commit to BM123499/Stockfish that referenced this pull request Feb 22, 2021
STC https://tests.stockfishchess.org/tests/view/5f2955b1a5abc164f05e4c85
LLR: 2.96 (-2.94,2.94) {-1.50,0.50}
Total: 29216 W: 5560 L: 5416 D: 18240
Ptnml(0-2): 466, 3329, 6902, 3417, 494

LTC https://tests.stockfishchess.org/tests/view/5f299154a5abc164f05e4ca1
LLR: 2.92 (-2.94,2.94) {-1.50,0.50}
Total: 54144 W: 6635 L: 6594 D: 40915
Ptnml(0-2): 372, 4859, 16536, 4966, 339

closes official-stockfish#2910

Bench: 4609008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants