Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSV3_1 #295

Closed
wants to merge 1 commit into from
Closed

PSV3_1 #295

wants to merge 1 commit into from

Conversation

Rocky640
Copy link

Small speed-up in pawn.cpp
No functional change
Results for 10 tests for each version:

Base Test Diff
Mean 1435636 1445238 -9602
StDev 22576 23189 1848

p-value: 1
speedup: 0.007

Small speed-up in pawn.cpp
No functional change
Results for 10 tests for each version:

Base      Test      Diff
Mean    1435636   1445238   -9602
StDev   22576     23189     1848

p-value: 1
speedup: 0.007
@locutus2
Copy link
Member

In this form this is a functional change because you use other backward pawn values

@Rocky640
Copy link
Author

In the current master code, a "backward" pawn is ALWAYS an "unsupported" pawn (since we exclude connected pawns)

Here I changed "backward" penalties for ("backward" + "unsupported" S(20,10) )
and changed the logic to avoid the "unsupported" addition again.

So whatever bench you can think of, it will ALWAYS give the same result.

This is also consistent with what was done with the Isolated pawns (the unsupported weight was already included)
This also has the merit to illustrate more clearly that the overall penalty for a backward pawn is greater than for an Isolated pawn, which I find rather surprising especially in the opposed case. I'm currently doing some local tests on those weights.
Finally, it groups all the "unsupported" cases together, (isolated, backward, and unsupported) which opens the way for some eventual simplifications.

@mcostalba
Copy link

mcostalba commented Mar 16, 2015 via email

@hxim
Copy link

hxim commented Mar 16, 2015

My results:
Results for 20 tests for each version:

        Base      Test      Diff      
Mean    1279453   1284523   -5070     
StDev   1721      3313      2615      

p-value: 0,974

@glinscott
Copy link
Contributor

Cool, looks good.

@Rocky640
Copy link
Author

A simplification test is about to be run.
I suggest to wait for the result before committing this small speed-up.

@mstembera
Copy link
Contributor

Maybe too late but simplifications should always run against the best current known version. So applying this first and then running the simplification against this would have been better.

@zamar
Copy link

zamar commented Mar 28, 2015

approved. This patch makes sense logically.

@glinscott glinscott closed this in 8463fa4 Mar 28, 2015
@Rocky640 Rocky640 deleted the PawnSpeedV3 branch August 20, 2015 01:05
niklasf pushed a commit to niklasf/Stockfish that referenced this pull request Mar 28, 2017
Tweak bishop mobility bonus for horde chess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants