-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner make help #3071
Cleaner make help #3071
Conversation
do not print details if ARCH is an empty string. Follow up for b0b4ca1 No functional change
to prevent user errors or generating untested code, check explicitly that the ARCH variable is equivalent to a supported architecture as listed in `make help`. To nevertheless compile for an untested target the user can override the internal variable, passing the undocumented `SUPPORTED_ARCH=true` to make. closes #3062 No functional change.
With this version, the following does not compile: make clean Config: Flags: Testing config sanity. If this fails, try 'make help' ... |
well so the question is if we want to support compiling without an ARCH= flag. This would only work on one specific architecture (x86-64), and not e.g. on arm (RPI, Android), and is also not documented (AFAIK). Maybe we should remove the ARCH=x86-64-modern default? |
I would keep it, please. It makes it so much simpler to ask for a rapid test for users with problems in the forum on in Github issues, and it has been documented in the Makefile for ages since we said that x86-64-modern is "default". |
so, added back the default x86-64... not so sure this is best in the light of some hardware updates ;-) |
do not print details if ARCH is an empty string. Follow up for b0b4ca1 official-stockfish#3071 No functional change
do not print details if ARCH is an empty string. Follow up for b0b4ca1 official-stockfish/Stockfish#3071 No functional change
do not print details if ARCH is an empty string. Follow up for b0b4ca1 official-stockfish#3071 No functional change
do not print details if ARCH is an empty string. Follow up for b0b4ca1
No functional change