Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner make help #3071

Closed
wants to merge 2 commits into from
Closed

Conversation

vondele
Copy link
Member

@vondele vondele commented Aug 26, 2020

do not print details if ARCH is an empty string. Follow up for b0b4ca1

No functional change

do not print details if ARCH is an empty string. Follow up for b0b4ca1

No functional change
vondele referenced this pull request Aug 26, 2020
to prevent user errors or generating untested code,
check explicitly that the ARCH variable is equivalent to a supported architecture
as listed in `make help`.

To nevertheless compile for an untested target the user can override the internal
variable, passing the undocumented `SUPPORTED_ARCH=true` to make.

closes #3062

No functional change.
@snicolet
Copy link
Member

snicolet commented Aug 26, 2020

With this version, the following does not compile:

make clean
make build

Config:
debug: 'no'
sanitize: 'no'
optimize: 'yes'
arch: 'x86_64'
bits: '64'
kernel: 'Darwin'
os: ''
prefetch: 'yes'
popcnt: 'yes'
pext: 'no'
sse: 'yes'
mmx: 'no'
sse2: 'yes'
ssse3: 'yes'
sse41: 'yes'
avx2: 'no'
avx512: 'no'
vnni256: 'no'
vnni512: 'no'
neon: 'no'

Flags:
CXX: g++-mp-10
CXXFLAGS: -Wall -Wcast-qual -fno-exceptions -std=c++17 -pedantic -Wextra -Wshadow -m64 -arch x86_64 -mmacosx-version-min=10.14 -DUSE_PTHREADS -DNDEBUG -O3 -mdynamic-no-pic -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -flto
LDFLAGS: -m64 -arch x86_64 -mmacosx-version-min=10.14 -lpthread -Wall -Wcast-qual -fno-exceptions -std=c++17 -pedantic -Wextra -Wshadow -m64 -arch x86_64 -mmacosx-version-min=10.14 -DUSE_PTHREADS -DNDEBUG -O3 -mdynamic-no-pic -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -flto -flto=jobserver

Testing config sanity. If this fails, try 'make help' ...

@vondele
Copy link
Member Author

vondele commented Aug 26, 2020

well so the question is if we want to support compiling without an ARCH= flag. This would only work on one specific architecture (x86-64), and not e.g. on arm (RPI, Android), and is also not documented (AFAIK). Maybe we should remove the ARCH=x86-64-modern default?

@snicolet
Copy link
Member

I would keep it, please.

It makes it so much simpler to ask for a rapid test for users with problems in the forum on in Github issues, and it has been documented in the Makefile for ages since we said that x86-64-modern is "default".

@vondele
Copy link
Member Author

vondele commented Aug 26, 2020

so, added back the default x86-64... not so sure this is best in the light of some hardware updates ;-)

@vondele vondele added the to be merged Will be merged shortly label Aug 30, 2020
vondele added a commit to vondele/Stockfish that referenced this pull request Aug 30, 2020
do not print details if ARCH is an empty string. Follow up for b0b4ca1

official-stockfish#3071

No functional change
@vondele vondele closed this Aug 30, 2020
lucabrivio pushed a commit to lucabrivio/Stockfish that referenced this pull request Aug 30, 2020
do not print details if ARCH is an empty string. Follow up for b0b4ca1

official-stockfish/Stockfish#3071

No functional change
Dantist pushed a commit to Dantist/Stockfish that referenced this pull request Dec 22, 2020
do not print details if ARCH is an empty string. Follow up for b0b4ca1

official-stockfish#3071

No functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants