Add comments to uncommented parts of code. #3250
Conversation
|
https://github.com/official-stockfish/Stockfish/pull/3250/files#diff-da923b7afa45cab7add143c4705b54142e46b2afe9a2627d5fa3b3474bdc8aecR1729 |
src/evaluate.cpp
Outdated
| else | ||
| sf = 22 + 3 * pos.count<ALL_PIECES>(strongSide); | ||
| } | ||
| // For rook endgames with strong side not having overwhelming pawn number advantage | ||
| // and it pawns being on one flank |
src/evaluate.cpp
Outdated
| else | ||
| sf = 22 + 3 * pos.count<ALL_PIECES>(strongSide); | ||
| } | ||
| // For rook endgames with strong side not having overwhelming pawn number advantage | ||
| // and it pawns being on one flank | ||
| // and weak side protecting it pieces with a king |
There was a problem hiding this comment.
and weak side protecting its pieces with a king
src/search.cpp
Outdated
| @@ -1248,6 +1261,7 @@ namespace { | |||
| { | |||
| value = -search<NonPV>(pos, ss+1, -(alpha+1), -alpha, newDepth, !cutNode); | |||
|
|
|||
| // If the move passed LMR update it stats | |||
There was a problem hiding this comment.
If the move passed LMR update its stats
src/search.cpp
Outdated
| @@ -1333,6 +1346,7 @@ namespace { | |||
| } | |||
| } | |||
|
|
|||
| // If move is worse than some previously searched move remember it to update it stats later | |||
There was a problem hiding this comment.
If move is worse than some previously searched move remember it to update its stats later
There was a problem hiding this comment.
Actually, a comma and a the are missing, too.
Should be: If the move is worse than some previously searched move, remember it to update its stats later
src/search.cpp
Outdated
| for (int i = 0; i < quietCount; ++i) | ||
| { | ||
| thisThread->mainHistory[us][from_to(quietsSearched[i])] << -bonus2; | ||
| update_continuation_histories(ss, pos.moved_piece(quietsSearched[i]), to_sq(quietsSearched[i]), -bonus2); | ||
| } | ||
| } | ||
| else | ||
| // Increase stats for the best move in case it wa a capture move |
There was a problem hiding this comment.
Increase stats for the best move in case it was a capture move
|
completely forgot to comment this line 1744/1767 of search, should be smth like |
|
@Vizvezdenec please update the patch with the review comments, so I can merge it in a next round |
|
Done. |
official-stockfish#3250 No functional change
|
thanks, also @crossbr for the review |
official-stockfish#3250 No functional change
A lot of latest patches are not commented properly which doesn't help in understanding what parts of code actually do (mine included).
So add/clarify code in evaluate and search.
No functional change.
bench 3561701