Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the formulas for unsafeSquares #3268

Closed
wants to merge 2 commits into from
Closed

Tweak the formulas for unsafeSquares #3268

wants to merge 2 commits into from

Conversation

FauziAkram
Copy link
Contributor

@FauziAkram FauziAkram commented Dec 20, 2020

Follow-up to recent #3266

We give more bonus for a special case If there are some enemy squares occupied or attacked by the enemy on the passed pawn span, but if they are all attacked by our pawn, use new intermediate factor 30.

The main credit goes to Rocky for the idea, and to me for the tuning and tests.

Passed STC:
LLR: 2.95 (-2.94,2.94) {-0.25,1.25}
Total: 96464 W: 19233 L: 18834 D: 58397
Ptnml(0-2): 1683, 11327, 21950, 11452, 1820
https://tests.stockfishchess.org/tests/view/5fdd21ab3932f79192d39357

Passed LTC:
LLR: 2.94 (-2.94,2.94) {0.25,1.25}
Total: 81320 W: 10784 L: 10352 D: 60184
Ptnml(0-2): 602, 7524, 24044, 7820, 670
https://tests.stockfishchess.org/tests/view/5fddec983932f79192d393a4

Bench: 4338972
@anshulongithub
Copy link

@FauziAkram, Isn't a 0 missing on line 799 after 7 :, in the tested patch i see 7 : 0 for the ternary operator

Bench: 4338972
Copy link
Contributor Author

@FauziAkram FauziAkram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshulongithub that's right, thanks for pointing it out, fixed.

src/evaluate.cpp Show resolved Hide resolved
@FauziAkram
Copy link
Contributor Author

@vondele Fishtest is currently empty, if you can merge the 2 pending patches I can start with my new set of tests

@vondele vondele added the to be merged Will be merged shortly label Dec 23, 2020
@vondele vondele closed this in 45b0532 Dec 23, 2020
joergoster pushed a commit to joergoster/Stockfish-old that referenced this pull request Dec 25, 2020
We give more bonus for a special case: If there are some enemy squares occupied
or attacked by the enemy on the passed pawn span,
but if they are all attacked by our pawn, use new intermediate factor 30.

The main credit goes to Rocky for the idea, with additional tuning and tests.

Passed STC:
LLR: 2.95 (-2.94,2.94) {-0.25,1.25}
Total: 96464 W: 19233 L: 18834 D: 58397
Ptnml(0-2): 1683, 11327, 21950, 11452, 1820
https://tests.stockfishchess.org/tests/view/5fdd21ab3932f79192d39357

Passed LTC:
LLR: 2.94 (-2.94,2.94) {0.25,1.25}
Total: 81320 W: 10784 L: 10352 D: 60184
Ptnml(0-2): 602, 7524, 24044, 7820, 670
https://tests.stockfishchess.org/tests/view/5fddec983932f79192d393a4

closes official-stockfish/Stockfish#3268

Bench: 4338972
BM123499 pushed a commit to BM123499/Stockfish that referenced this pull request Feb 22, 2021
We give more bonus for a special case: If there are some enemy squares occupied
or attacked by the enemy on the passed pawn span,
but if they are all attacked by our pawn, use new intermediate factor 30.

The main credit goes to Rocky for the idea, with additional tuning and tests.

Passed STC:
LLR: 2.95 (-2.94,2.94) {-0.25,1.25}
Total: 96464 W: 19233 L: 18834 D: 58397
Ptnml(0-2): 1683, 11327, 21950, 11452, 1820
https://tests.stockfishchess.org/tests/view/5fdd21ab3932f79192d39357

Passed LTC:
LLR: 2.94 (-2.94,2.94) {0.25,1.25}
Total: 81320 W: 10784 L: 10352 D: 60184
Ptnml(0-2): 602, 7524, 24044, 7820, 670
https://tests.stockfishchess.org/tests/view/5fddec983932f79192d393a4

closes official-stockfish#3268

Bench: 4338972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants