Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify away late irreversible move extension #3279

Closed
wants to merge 1 commit into from
Closed

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Dec 27, 2020

STC https://tests.stockfishchess.org/tests/view/5fe75c5c3932f79192d398ca
LLR: 2.93 (-2.94,2.94) {-1.25,0.25}
Total: 196192 W: 18111 L: 18278 D: 159803
Ptnml(0-2): 681, 14097, 68652, 14040, 626

LTC https://tests.stockfishchess.org/tests/view/5fe875e23932f79192d39952
LLR: 2.96 (-2.94,2.94) {-0.75,0.25}
Total: 28080 W: 1105 L: 1053 D: 25922
Ptnml(0-2): 13, 904, 12158, 948, 17

bench: 4075243

Late irreversible move extension seems to be useless. Some ELO estimation: https://tests.stockfishchess.org/tests/view/5fe72efb3932f79192d39889

STC https://tests.stockfishchess.org/tests/view/5fe75c5c3932f79192d398ca
LLR: 2.93 (-2.94,2.94) {-1.25,0.25}
Total: 196192 W: 18111 L: 18278 D: 159803
Ptnml(0-2): 681, 14097, 68652, 14040, 626

LTC https://tests.stockfishchess.org/tests/view/5fe875e23932f79192d39952
LLR: 2.96 (-2.94,2.94) {-0.75,0.25}
Total: 28080 W: 1105 L: 1053 D: 25922
Ptnml(0-2): 13, 904, 12158, 948, 17

bench: 4075243

Late irreversible move extension seems to be useless. Some ELO estimation: https://tests.stockfishchess.org/tests/view/5fe72efb3932f79192d39889
@AlexandreMasta
Copy link

AlexandreMasta commented Dec 28, 2020

1 elo is useless. One more elo loss by Unaiic. Great contribution man! Congratz!

Making your name shine in the Developers´ list by using tons of simplifications tests. Very nice!

@ddugovic
Copy link

I guess an alternative could be to try to tune pos.rule50_count() > 80 to some other constant so the NN doesn't need to be aware of this sort of "beware of 50 move rule" search policy.

@Yery
Copy link

Yery commented Dec 28, 2020

On the importance of simplifications: I cannot easily find a good post of Marco Costalba on this topic - but the bottom line is that a program full of useless code becomes very quickly unmanageable and difficult to optimize or to improve. Simplifications have always been at the heart of stockfish and they have been key for the success and longevity of the stockfish project.

@Vizvezdenec
Copy link
Contributor

You understand that REMOVAL of it had +1 elo performance, not it introduction, right?

@vondele vondele added the to be merged Will be merged shortly label Dec 31, 2020
@vondele vondele closed this in 8985c21 Dec 31, 2020
@unaiic unaiic deleted the mp branch April 9, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants