Collective Cleanups February 2021

[Lolligerhans]

Merge/pull with --squash to prepare single commit in staging index, commit with git commit.
Created empty following request from #3301.

---

What is a cleanup?

(Trivial) cleanups are changes which do not require testing, because their benefit is apparent to everyone. This can include

• Spelling and orthography corrections
• Code style harmonization/homogenization
• Commentary refinement
• (Other small changes of evident benefit)

Participation

You have two options to add your own cleanups:

1. Create a separate PR on my branch trivial-cleanups_Feb2021 to my fork of Stockfish. This allows me to to easily merge your ideas, if they require large or complex changes.
2. For simple changes, comment below and I add them for you.

Legend

👀 = I have seen your comment
👍 = Comment is resolved or discussed further below

[BM123499]

Missing constexpr on score in movepick.cpp

[BM123499]

@Lolligerhans, I meant inside... ;)

[Lolligerhans]

@BM123499 I saw you test now and figured! xD The function one is on the house. 👍

[BM123499]

we are using constexpr in many places, but can they be used on line 428 of evaluate.cpp?

[Lolligerhans]

we are using constexpr in many places, but can they be used on line 428 of evaluate.cpp?

@BM123499 Please add a commit with a concrete suggestion. You will need to address the defined-not-used warning resulting from excluding all uses of some of the constexpr variables from the function body. I originally just omitted this case for simplicity (keeping all constexpr definitions in a block at start), but surely there are technical solutions for this problem.

[snicolet]

Line 271-272 of position.cpp should be formatted like this:

               && (   file_of(square<KING>(sideToMove)) == file_of(st->epSquare)
                   || !(blockers_for_king(sideToMove) & (st->epSquare + pawn_push(~sideToMove))));

[snicolet]

Lines 521-522 of position.cpp should be like this:

      return    !(st->previous->blockersForKing[sideToMove] & from)
             || aligned(from, to, square<KING>(us));

EDIT: removed the faulty de Morgan law, sorry. Corrected to just push the ||on second line.

[snicolet]

Lines 660-661 of position.cpp should be formatted like this:

      return   st->previous->checkersBB 
            || (   rank_of(square<KING>(~sideToMove)) == rank_of(from)
                && (st->previous->blockersForKing[~sideToMove] & from));

[BM123499]

Lines 521-522 of position.cpp should be like this:

      return    !(st->previous->blockersForKing[sideToMove] & from)
             && !aligned(from, to, square<KING>(us));

@snicolet it changes the logic.

[Lolligerhans]

Adjusted whitespace to follow suggested indentation. Kept original expressions where suggested corrections differ (as pointed out by BM123499). I suppose these suggestions were accidental (?)

[snicolet]

Yes, sorry :-)
Corrected to just push the || operator on the second line in lines 521-522.

[vondele]

fix copyright date in Makefile

[Lolligerhans]

fix copyright date in Makefile

@vondele
(1) Adding for time until today or

 # Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
 # Copyright (C) 2008-2015 Marco Costalba, Joona Kiiski, Tord Romstad
 # Copyright (C) 2015-2019 Marco Costalba, Joona Kiiski, Gary Linscott, Tord Romstad
+# Copyright (C) 2019-2021 The Stockfish developers (see AUTHORS file)
 #
 # Stockfish is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

(2) replacing entire time span?

 # Stockfish, a UCI chess playing engine derived from Glaurung 2.1
-# Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
-# Copyright (C) 2008-2015 Marco Costalba, Joona Kiiski, Tord Romstad
-# Copyright (C) 2015-2019 Marco Costalba, Joona Kiiski, Gary Linscott, Tord Romstad
+# Copyright (C) 2004-2021 The Stockfish developers (see AUTHORS file)
 #
 # Stockfish is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

[snicolet]

I would go for option (2) replacing entire time span, as in other source files.

[snicolet]

for search.cpp:
• lines 1030-1034 (in the likelyFailLow block): trailing spaces at end of lines
• line 1083: trailing space
• line 1084: end of two lines comment is missing a point.

[snicolet]

Merged via 40cb0f0, thanks :-)