-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Movegen #3399
Closed
Closed
Simplify Movegen #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snicolet
pushed a commit
that referenced
this pull request
Mar 16, 2021
STC: LLR: 2.97 (-2.94,2.94) {-1.25,0.25} Total: 39352 W: 3551 L: 3493 D: 32308 Ptnml(0-2): 143, 2695, 13928, 2781, 129 https://tests.stockfishchess.org/tests/view/6050007a2433018de7a38bbb LTC: LLR: 2.96 (-2.94,2.94) {-0.75,0.25} Total: 44944 W: 1629 L: 1596 D: 41719 Ptnml(0-2): 22, 1319, 19762, 1342, 27 https://tests.stockfishchess.org/tests/view/60500e892433018de7a38bc4 Closes #3399 No functional change
@snicolet Sorry for that... 😅 I didn't want to flood PR section. I'll do it separated next time. |
MichaelB7
pushed a commit
to MichaelB7/Stockfish
that referenced
this pull request
Apr 13, 2021
STC: LLR: 2.95 (-2.94,2.94) {-1.25,0.25} Total: 29792 W: 2611 L: 2545 D: 24636 Ptnml(0-2): 94, 1982, 10659, 2086, 75 https://tests.stockfishchess.org/tests/view/604fe5b62433018de7a38ba8 LTC: LLR: 2.92 (-2.94,2.94) {-0.75,0.25} Total: 22040 W: 826 L: 777 D: 20437 Ptnml(0-2): 8, 646, 9664, 693, 9 https://tests.stockfishchess.org/tests/view/604fec892433018de7a38bac Closes official-stockfish#3399 No functional change
MichaelB7
pushed a commit
to MichaelB7/Stockfish
that referenced
this pull request
Apr 13, 2021
STC: LLR: 2.97 (-2.94,2.94) {-1.25,0.25} Total: 39352 W: 3551 L: 3493 D: 32308 Ptnml(0-2): 143, 2695, 13928, 2781, 129 https://tests.stockfishchess.org/tests/view/6050007a2433018de7a38bbb LTC: LLR: 2.96 (-2.94,2.94) {-0.75,0.25} Total: 44944 W: 1629 L: 1596 D: 41719 Ptnml(0-2): 22, 1319, 19762, 1342, 27 https://tests.stockfishchess.org/tests/view/60500e892433018de7a38bc4 Closes official-stockfish#3399 No functional change
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
May 7, 2021
STC: LLR: 2.95 (-2.94,2.94) {-1.25,0.25} Total: 29792 W: 2611 L: 2545 D: 24636 Ptnml(0-2): 94, 1982, 10659, 2086, 75 https://tests.stockfishchess.org/tests/view/604fe5b62433018de7a38ba8 LTC: LLR: 2.92 (-2.94,2.94) {-0.75,0.25} Total: 22040 W: 826 L: 777 D: 20437 Ptnml(0-2): 8, 646, 9664, 693, 9 https://tests.stockfishchess.org/tests/view/604fec892433018de7a38bac Closes official-stockfish/Stockfish#3399 No functional change
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
May 7, 2021
STC: LLR: 2.97 (-2.94,2.94) {-1.25,0.25} Total: 39352 W: 3551 L: 3493 D: 32308 Ptnml(0-2): 143, 2695, 13928, 2781, 129 https://tests.stockfishchess.org/tests/view/6050007a2433018de7a38bbb LTC: LLR: 2.96 (-2.94,2.94) {-0.75,0.25} Total: 44944 W: 1629 L: 1596 D: 41719 Ptnml(0-2): 22, 1319, 19762, 1342, 27 https://tests.stockfishchess.org/tests/view/60500e892433018de7a38bc4 Closes official-stockfish/Stockfish#3399 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On patch 1, I rewrote the patch #3300 that Sopel made, so it's more reader-friendly.
On patch 2, it's a small simplification. And I also believe it's more easy to understand what the value stands for.
Patch 1:
STC:
LLR: 2.95 (-2.94,2.94) {-1.25,0.25}
Total: 29792 W: 2611 L: 2545 D: 24636
Ptnml(0-2): 94, 1982, 10659, 2086, 75
https://tests.stockfishchess.org/tests/view/604fe5b62433018de7a38ba8
LTC:
LLR: 2.92 (-2.94,2.94) {-0.75,0.25}
Total: 22040 W: 826 L: 777 D: 20437
Ptnml(0-2): 8, 646, 9664, 693, 9
https://tests.stockfishchess.org/tests/view/604fec892433018de7a38bac
Patch 2:
STC:
LLR: 2.97 (-2.94,2.94) {-1.25,0.25}
Total: 39352 W: 3551 L: 3493 D: 32308
Ptnml(0-2): 143, 2695, 13928, 2781, 129
https://tests.stockfishchess.org/tests/view/6050007a2433018de7a38bbb
LTC:
LLR: 2.96 (-2.94,2.94) {-0.75,0.25}
Total: 44944 W: 1629 L: 1596 D: 41719
Ptnml(0-2): 22, 1319, 19762, 1342, 27
https://tests.stockfishchess.org/tests/view/60500e892433018de7a38bc4
No functional change