Simplify and unify FRC cornered bishop #3413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the NNUE correction function, the signs are different for the black bishops in A8 and H8, compared to master? |
bench: 4321677
|
@snicolet Ah, actually it's the A1 H1 signs I got wrong. I got confused when merging with the previous simplification. No change in bench. Thanks for catching that! I did the testing before the merger so no issue there. If you prefer to define CorneredBishopV to be negative and adjust everything accordingly just let me know. |
|
For me the patch tests well (NNUE FRC): Score of master vs patch: 6463 - 6580 - 34957 [0.499] 48000 |
MichaelB7
pushed a commit
to MichaelB7/Stockfish
that referenced
this pull request
Apr 13, 2021
tested locally as fishtest doesn't support FRC: STC NNUE 9646 - 9647 - 20707 [0.500] 40000 -0.0 +/- 2.4, LOS: 49.7 %, DrawRatio: 51.8 % STC classical 9678 - 9609 - 20713 [0.501] 40000 0.6 +/- 2.4, LOS: 69.0 %, DrawRatio: 51.8 % and verified independently: Score of master vs patch: 6463 - 6580 - 34957 [0.499] 48000 closes official-stockfish#3413 bench: 4321677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3405 (comment)
@snicolet suggested this simplification. I agree because in classical we give a larger penalty for a second blocking pawn on C3 but in NNUE we give a smaller penalty in the same situation.
I ran the below tests locally for patch vs master:
STC NNUE
9646 - 9647 - 20707 [0.500] 40000 -0.0 +/- 2.4, LOS: 49.7 %, DrawRatio: 51.8 %
STC classical
9678 - 9609 - 20713 [0.501] 40000 0.6 +/- 2.4, LOS: 69.0 %, DrawRatio: 51.8 %
I can run additional tests if requested but it would be nice if someone else could confirm no regression independently.
bench: 4321677