Recursive hell of vars #3859
Closed
Recursive hell of vars #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables had different behavior via recursive dependency hell. If there is no environment variable -> sometimes variable treated as local with correct behavior or no. If there is environment variable -> variable treated as global with multiple extending. E.g. CXXFLAGS="-march=native -DNNUE_EMBEDDING_OFF" make COMP=mingw ARCH=x86-64-modern -j3 profile-build CXX=x86_64-w64-mingw32-g++.exe ... x86_64-w64-mingw32-g++.exe -march=native -DNNUE_EMBEDDING_OFF -Wall -Wcast-qual -fno-exceptions -std=c++17 -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -Wall -Wcast-qual -fno-exceptions -std=c++17 -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -Wall -Wcast-qual -fno-exceptions -std=c++17 -fprofile-generate=profdir -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -c -o bitboard.o bitboard.cpp Now: CMDCXXFLAGS="-march=native -DNNUE_EMBEDDING_OFF" make COMP=mingw ARCH=x86-64-modern -j3 profile-build CXX=x86_64-w64-mingw32-g++.exe
|
Is there any particular reason that this patch hasn't been merged? |
|
I'm not convinced that introducing yet another variable is a good solution for the problem. Additionally, if this is introduced without documentation it doesn't help. I believe the proper solution is to make CXXFLAGS behave as expected. |
|
@vondele , check this. |
|
ping @vondele |
dav1312
pushed a commit
to dav1312/Stockfish
that referenced
this pull request
Oct 21, 2022
removes duplication on the commandline for example in a profile-build closes official-stockfish#3859 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables had different behavior via recursive dependency hell.
If there is no environment variable -> sometimes variable treated as local with correct behavior.
If there is environment variable -> variable treated as global with multiple extending.
E.g.
CXXFLAGS="-march=native -DNNUE_EMBEDDING_OFF" make COMP=mingw ARCH=x86-64-modern -j3 profile-build CXX=x86_64-w64-mingw32-g++.exe
Was:
x86_64-w64-mingw32-g++.exe -march=native -DNNUE_EMBEDDING_OFF -Wall -Wcast-qual -fno-exceptions -std=c++17 -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -Wall -Wcast-qual -fno-exceptions -std=c++17 -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -Wall -Wcast-qual -fno-exceptions -std=c++17 -fprofile-generate=profdir -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -c -o bitboard.o bitboard.cpp
Now:
x86_64-w64-mingw32-c++ -Wall -Wcast-qual -fno-exceptions -std=c++17 -fprofile-generate=profdir -march=native -DNNUE_EMBEDDING_OFF -pedantic -Wextra -Wshadow -DNDEBUG -O3 -DIS_64BIT -msse -msse3 -mpopcnt -DUSE_POPCNT -DUSE_SSE41 -msse4.1 -DUSE_SSSE3 -mssse3 -DUSE_SSE2 -msse2 -c -o bitboard.o bitboard.cpp
...