Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize transform2 #3955

Conversation

Chaneybenjamini
Copy link
Contributor

No description provided.

vondele and others added 2 commits March 1, 2022 22:55
…t are architecture defined instead of using a seperate code path for each one. It should make some old architectures (MMX) faster and make further such improvements easier in the future. No functional or performance change is expected for modern architectures.
@vondele
Copy link
Member

vondele commented Mar 2, 2022

@Fanael can you have a look if this patch works for you as a replacement of #3928 ?

@vondele vondele mentioned this pull request Mar 2, 2022
@Fanael
Copy link
Contributor

Fanael commented Mar 2, 2022

👍

@vondele
Copy link
Member

vondele commented Mar 2, 2022

looks good to me. @Chaneybenjamini can you please add an entry to the AUTHORS file, I'll merge afterwards.

@Chaneybenjamini
Copy link
Contributor Author

I added myself. Thank you for your help with this PR.

@vondele vondele added the to be merged Will be merged shortly label Mar 2, 2022
@vondele vondele closed this in 270a0e7 Mar 2, 2022
dav1312 pushed a commit to dav1312/Stockfish that referenced this pull request Oct 21, 2022
This commit generalizes the feature transform to use vec_t macros
that are architecture defined instead of using a seperate code path for each one.

It should make some old architectures (MMX, including improvements by Fanael) faster
and make further such improvements easier in the future.

Includes some corrections to CI for mingw.

closes official-stockfish#3955
closes official-stockfish#3928

No functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants