Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize checks in movepicker #4165

Closed
wants to merge 1 commit into from
Closed

Prioritize checks in movepicker #4165

wants to merge 1 commit into from

Conversation

mstembera
Copy link
Contributor

STC: https://tests.stockfishchess.org/tests/view/631da742162491686d2e40b5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 80072 W: 21753 L: 21368 D: 36951
Ptnml(0-2): 421, 8876, 21075, 9225, 439

LTC: https://tests.stockfishchess.org/tests/view/631dd9e6b85daa436625de1d
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 263480 W: 70916 L: 70158 D: 122406
Ptnml(0-2): 322, 26156, 78029, 26908, 325

Original idea by @Vizvezdenec. Credit to him.
bench: 4332915

Prioritize checks in movepicker
9c41e4f 
Original idea by @Vizvezdenec.  Credit to him.
bench: 4332915
@pb00067
Copy link

pb00067 commented Sep 16, 2022 •
edited

@mstembera

Original idea by @Vizvezdenec. Credit to him.

Really? To which tests of Vizvezdenec do you refer?

Are they before my first tests passing at STC?
https://tests.stockfishchess.org/tests/view/627a3c4084890d1785a5c830
https://tests.stockfishchess.org/tests/view/627a3f7f84890d1785a5c8bc

@Vizvezdenec
Copy link
Contributor

Vizvezdenec commented Sep 16, 2022 •
edited

@mstembera

Original idea by @Vizvezdenec. Credit to him.

Really? To which tests of Vizvezdenec do you refer?

Are they before my first tests passing at STC? https://tests.stockfishchess.org/tests/view/627a3c4084890d1785a5c830 https://tests.stockfishchess.org/tests/view/627a3f7f84890d1785a5c8bc

It only means that great minds think alike :) I haven't noticed this tests tbh...

@pb00067
Copy link

pb00067 commented Sep 16, 2022 •
edited

I haven't noticed this tests tbh...

I don't believe you Vizvezdenec, you started your tests just 4 days after mine.
https://tests.stockfishchess.org/tests/view/627fed07ab44257388ab23b1

@Vizvezdenec
Copy link
Contributor

I don't care what you believe in. For me it was 1250 tests apart from now so I don't even remember this.

@mstembera
Copy link
Contributor Author

@pb00067 Nothing nefarious going on here. The descriptions of my tests have a link to the test I was referring to. It is the test I saw that gave me the idea. Looks like your tests are even more similar and came first. I simply wasn't aware of them. No problem giving you credit Now how do we know nobody tried it even before you? :)

@AlexandreMasta
Copy link

The ego´s fight. Mmmm Pride...the Devil´s loved sin.

@TheBlackPlague
Copy link

@pb00067 Nothing nefarious going on here. The descriptions of my tests have a link to the test I was referring to. It is the test I saw that gave me the idea. Looks like your tests are even more similar and came first. I simply wasn't aware of them. No problem giving you credit Now how do we know nobody tried it even before you? :)

Well, @Vizvezdenec tried it ages ago. Even I suggested this idea months ago (Viz said he had tried it). So yeah, I would say giving Viz credit here is appropriate.

@vondele vondele added the to be merged Will be merged shortly label Sep 17, 2022
@vondele vondele closed this in dc0c441 Sep 17, 2022
PikaCat-OuO pushed a commit to official-pikafish/Pikafish that referenced this pull request Sep 17, 2022
Prioritize checks in movepicker
39a6851 
give a little bonus for moving pieces to squares where they give check

STC: https://tests.stockfishchess.org/tests/view/631da742162491686d2e40b5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 80072 W: 21753 L: 21368 D: 36951
Ptnml(0-2): 421, 8876, 21075, 9225, 439

LTC: https://tests.stockfishchess.org/tests/view/631dd9e6b85daa436625de1d
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 263480 W: 70916 L: 70158 D: 122406
Ptnml(0-2): 322, 26156, 78029, 26908, 325

similar ideas have been tested by Viz and Guenther

closes official-stockfish/Stockfish#4165

bench: 4326572
PikaCat-OuO pushed a commit to official-pikafish/Pikafish that referenced this pull request Sep 19, 2022
Prioritize checks in movepicker
6c461f1 
give a little bonus for moving pieces to squares where they give check

STC: https://tests.stockfishchess.org/tests/view/631da742162491686d2e40b5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 80072 W: 21753 L: 21368 D: 36951
Ptnml(0-2): 421, 8876, 21075, 9225, 439

LTC: https://tests.stockfishchess.org/tests/view/631dd9e6b85daa436625de1d
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 263480 W: 70916 L: 70158 D: 122406
Ptnml(0-2): 322, 26156, 78029, 26908, 325

similar ideas have been tested by Viz and Guenther

closes official-stockfish/Stockfish#4165

bench: 4326572
PikaCat-OuO pushed a commit to official-pikafish/Pikafish that referenced this pull request Oct 7, 2022
Prioritize checks in movepicker
f515a86 
give a little bonus for moving pieces to squares where they give check

STC: https://tests.stockfishchess.org/tests/view/631da742162491686d2e40b5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 80072 W: 21753 L: 21368 D: 36951
Ptnml(0-2): 421, 8876, 21075, 9225, 439

LTC: https://tests.stockfishchess.org/tests/view/631dd9e6b85daa436625de1d
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 263480 W: 70916 L: 70158 D: 122406
Ptnml(0-2): 322, 26156, 78029, 26908, 325

similar ideas have been tested by Viz and Guenther

closes official-stockfish/Stockfish#4165

bench: 4326572
(cherry picked from commit 6c461f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
to be merged Will be merged shortly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mstembera @pb00067 @Vizvezdenec @AlexandreMasta @TheBlackPlague @vondele