Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root complexity pr #4515

Closed

Conversation

vondele
Copy link
Member

@vondele vondele commented Apr 9, 2023

The calculation of rootComplexity can't call eval when in check.
Doing so triggers an assert if compiled in debug mode when
the rootpos is evaluated using classical eval.

Fixes #4512

Passed STC:
https://tests.stockfishchess.org/tests/view/6432697431feee5c6d306876
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 41096 W: 11017 L: 10815 D: 19264
Ptnml(0-2): 113, 4172, 11780, 4366, 117

Passed LTC:
https://tests.stockfishchess.org/tests/view/6432974d31feee5c6d306fc0
...

No functional change

The calculation of rootComplexity can't call eval when in check.
Doing so triggers an assert if compiled in debug mode when
the rootpos is evaluated using classical eval.

Fixes official-stockfish#4512

Passed STC:
https://tests.stockfishchess.org/tests/view/6432697431feee5c6d306876
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 41096 W: 11017 L: 10815 D: 19264
Ptnml(0-2): 113, 4172, 11780, 4366, 117

Passed LTC:
https://tests.stockfishchess.org/tests/view/6432974d31feee5c6d306fc0
...

No functional change
@vondele vondele closed this in b36d39d Apr 9, 2023
xoto10 pushed a commit to xoto10/stockfish-xoto10 that referenced this pull request Apr 9, 2023
xoto10 pushed a commit to xoto10/stockfish-xoto10 that referenced this pull request Apr 11, 2023
xoto10 pushed a commit to xoto10/stockfish-xoto10 that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For rootComplexity eval is called even if in check
1 participant