New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes a few Bitboards and functions that are not used #4695

Closed

rn5f107s2 wants to merge 1 commit into official-stockfish:master from rn5f107s2:Cleanup

Contributor

rn5f107s2 commented Jul 17, 2023 •

edited

No functional change

Contributor

UniQP commented Jul 17, 2023

@MaximMolchanov pointed out earlier today in Discord that the following functions are unused as well:

position.h:
bool is_on_semiopen_file(Color c, Square s) const;
bool pawn_passed(Color c, Square s) const;
bool opposite_bishops() const;
int  pawns_on_same_color_squares(Color c, Square s) const;
Score psq_score() const;

bitboard.h:
int edge_distance(Rank r);

Removing them renders even more functions in bitboard.h unused. Can you remove all these functions as part of this PR?


          Removes a few Bitboards and functions that are not used

ae3f505

rn5f107s2 force-pushed the Cleanup branch from 91554ce to ae3f505 Compare

July 17, 2023 21:15

vondele added the to be merged label

vondele closed this in

42d2842

vondele mentioned this pull request

Unused Code Cleanup #4696

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment