Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CPU archs in CI Tests workflow #4718

Closed
wants to merge 1 commit into from
Closed

Add new CPU archs in CI Tests workflow #4718

wants to merge 1 commit into from

Conversation

ppigazzini
Copy link
Contributor

@ppigazzini ppigazzini commented Jul 31, 2023

@snicolet
Copy link
Member

snicolet commented Jul 31, 2023

Thanks for the PR :-)

It is not exactly related to your patch, but I have a general question concerning the artifact binaries we compile via Github actions: do we use fixed gcc and clang compiler versions, or always ask for the latest gcc/clang versions?

It seems to me that using the latest compiler versions is risky, because compilers could introduce bugs in their updates (it happened to us before, and we sent a crashing SF binary to TCEC because of a bug in the pthread library used by a specific gcc version) and we would not have time to test enough if the compiler changes just before a major SF release.

We could even go as far as deciding that all SF 17 development should be made using the same compiler.

@ppigazzini
Copy link
Contributor Author

ppigazzini commented Jul 31, 2023

Windows binaries are built with gcc from msys2, which is a rolling distribution. I encountered a loop of dependency for some packages when I tried to downgrade by hand to an earlier version of msys2 gcc. We can switch to a msys2 clang build In case of an issue with the last version of msys2 gcc.
For Linux we are setting gcc 11.

- name: Install fixed GCC on Linux
if: runner.os == 'Linux'
uses: egor-tensin/setup-gcc@v1
with:
version: 11

@snicolet snicolet added the to be merged Will be merged shortly label Aug 6, 2023
@snicolet snicolet closed this in 4c43e1e Aug 6, 2023
@ppigazzini ppigazzini deleted the github_ci branch August 6, 2023 20:32
@snicolet
Copy link
Member

snicolet commented Aug 6, 2023

Merged via 4c43e1e, thanks :-)

Thanks also for the clarification on the compiler for our binaries. I would think the rolling distribution for Windows build may be a little bit dangerous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants