Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments #4801

Closed
wants to merge 11 commits into from
Closed

Conversation

FauziAkram
Copy link
Contributor

Improve comments.
Non-Functional

@cj5716
Copy link
Contributor

cj5716 commented Sep 23, 2023

I think you need to write "No functional change" to pass CI currently. Even if it doesn't, I still think it would be good to follow normal procedure.

@Disservin
Copy link
Member

I think you need to write "No functional change" to pass CI currently. Even if it doesn't, I still think it would be good to follow normal procedure.

you shouldnt need to right now

@dav1312
Copy link
Contributor

dav1312 commented Sep 23, 2023

If you are updating comments, please take this opportunity to update:

Stockfish/src/search.cpp

Lines 103 to 106 in 70ba9de

// Skill structure is used to implement strength limit. If we have an uci_elo then
// we convert it to a suitable fractional skill level using anchoring to CCRL Elo
// (goldfish 1.13 = 2000) and a fit through Ordo derived Elo for a match (TC 60+0.6)
// results spanning a wide range of k values.

@FauziAkram
Copy link
Contributor Author

FauziAkram commented Sep 23, 2023

@dav1312 Done.

bench: 1246812
src/search.cpp Outdated Show resolved Hide resolved
@Disservin Disservin added the to be merged Will be merged shortly label Sep 29, 2023
@Disservin Disservin closed this in 243f7b2 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-bench-change to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants