Remove unneeded operator overload macros

[miguel-l]

Only Direction type is using two of the enable overload macros. Aside from this, only two of the overloads are even being used.

Therefore, we can just define the needed overloads and remove the macros.

No functional change.

[Disservin]

looks good, some would probably argue it's good to have these for the future but I'd much rather remove them and then discuss the readdition of operator overloads when something pops up

[Sopel97]

The scope of operators should be defined by the type's semantics, not what's currently being used.

[miguel-l]

I think it's okay semantically to get rid of these as well. The macros are very specific to ints and I'm not sure stuff like subtracting or dividing a Direction by an int makes sense. Most existing overloads already handle semantics better (e.g. there are overloads for Square and Direction operations).

As for the ones I couldn't fully get rid of:

• For operator+, we actually don't need it. It was being (mis?)used for Up+Up in pawn push calculations. I've replaced the overload with one that accepts 2 directions instead of a direction and an int.

• operator* I could maybe make some sense of, but I'm really not sure. I'd probably remove it if I could but it's being used in a weird way for setting positions from fens.

[Disservin]

operator* I could maybe make some sense of, but I'm really not sure. I'd probably remove it if I could but it's being used in a weird way for setting positions from fens.

The 2 * SOUTH is a bit weird, because it means "go south two times when you encounter a /",
but it makes sense because on the last char before a / we increment it by 1, which essentially goes to the start of the previous row/rank and from that we go south two times.
I think we can just leave that as is?

Here's the commit which added those btw 822695d

[miguel-l]

The 2 * SOUTH is a bit weird, because it means "go south two times when you encounter a /", but it makes sense because on the last char before a / we increment it by 1, which essentially goes to the start of the previous row/rank and from that we go south two times. I think we can just leave that as is?

Yes, I left operator* on int as it is