Implement accumulator refresh table #5183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gab8192
force-pushed
the
finny-tables
branch
4 times, most recently
from
a02661a
to
0712cab
Compare
|
For future reference. |
Sopel97
suggested changes
Apr 20, 2024
Sopel97
reviewed
Apr 20, 2024
vondele
reviewed
Apr 22, 2024
vondele
reviewed
Apr 23, 2024
vondele
reviewed
Apr 23, 2024
Sopel97
reviewed
Apr 23, 2024
| // When we are refreshing the accumulator of the big net, | ||
| // redirect to the version of refresh that uses the refresh table. | ||
| // Using the cache for the small net is not beneficial. | ||
| if constexpr (HalfDimensions == Eval::NNUE::TransformedFeatureDimensionsBig) |
There was a problem hiding this comment.
I was thinking it might make more sense to decide whether to use the cache at the callsite, and here just check for nullptr. This part of the code shouldn't even know what a big net is
There was a problem hiding this comment.
Yea I am not a fan of having different behaviour inside the feature transformer for different network sizes, but I'd keep that as is for now since we've been testing the current version on fishtest right now and I think it is somewhat time to get it into master. I can take a look at that later again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each thread, keep a list of
AccumulatorRefreshEntry, one for each possible king square.An
AccumulatorRefreshEntrycontains the bitboards to represent the pieces of a position, and an accumulator.When the accumulator needs to be refreshed, instead of filling it with biases and adding every piece from scratch, we...
AccumulatorRefreshEntryassociated with the new king bucket(from differences between bitboards in the entry and bitboards of the actual position)
I believe the structure of this new feature isn't implemented very well and needs a refactoring.
Credits to Luecx/Finny, who originally came up with this idea.
Results at STC:
https://tests.stockfishchess.org/tests/live_elo/662301573fe04ce4cefc1386
No functional change