Optimise NNUE Accumulator updates

[cj5716]

Passed STC:
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 86176 W: 22284 L: 21905 D: 41987
Ptnml(0-2): 254, 9572, 23051, 9963, 248
https://tests.stockfishchess.org/tests/view/662e3c6a5e9274400985a741

closes #5202

No functional change

[mstembera]

Congrats!

[mstembera]

Does the assert([&]() run even in release builds which is not what we want ?

[Disservin]

Does the assert([&]() run even in release builds which is not what we want ?

i'm not quite sure I understand what you are asking? any assert is not run in release build and is not included in the binary?
This lambda runs in the assertion because at the theres a function call ()

[mstembera]

I was thinking the lambda assert overrides the normal default assert and maybe does not compile out in release builds like a normal assert does?

[ddobbelaere]

There is no such thing as a 'lambda assert'. The called lambda function is passed as an argument to assert, which is in fact a macro that does nothing if NDEBUG is defined (which is the case for release builds). See https://en.cppreference.com/w/cpp/error/assert

It's actually a clever idiom, never saw it before, but looks good.

[mstembera]

Ah my apologies I obviously can't read. Ty.