Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the EvalFile net option detection #1870

Merged
merged 1 commit into from Feb 23, 2024

Conversation

ppigazzini
Copy link
Collaborator

@ppigazzini ppigazzini commented Dec 19, 2023

Stockfish will use more than one net with
official-stockfish/Stockfish#4915

Get all the couples "option" and "net names" from the output of the
stockfish uci command.

Raise worker version to 227 (also server side)

@ppigazzini ppigazzini added worker update code changes requiring a worker update update code change to account external change (Stockfish, book etc.) labels Dec 19, 2023
@ppigazzini ppigazzini force-pushed the eval_file_small branch 4 times, most recently from 04a1794 to 6ae7a68 Compare December 20, 2023 14:14
@ppigazzini ppigazzini changed the title Generalize the EvalFile net option Generalize the EvalFile net option detection Dec 20, 2023
@ppigazzini ppigazzini force-pushed the eval_file_small branch 4 times, most recently from 244821c to 06ec203 Compare December 21, 2023 16:37
worker/games.py Outdated Show resolved Hide resolved
@mstembera
Copy link

@ppigazzini Thank you for this. Is this the last thing needed on the fishtest side before official-stockfish/Stockfish#4915 can be merged?

@mstembera
Copy link

@ppigazzini Can you please commit this so we can proceed with official-stockfish/Stockfish#4915 ? Ty!

@peregrineshahin
Copy link
Contributor

Maybe ppigazzini realized a big flaw in this PR and still thinking about the solution ;) ..

@Disservin
Copy link
Member

Disservin commented Jan 4, 2024

btw we should also update the memory requirements even though it's not much I guess.
The second net is 3MB, the current main net is estimated to be around 80MB in fishtest code which I think is still an old value, because the net file is around ~64MB.

Also fishtest and the worker are out of sync regarding that.
https://github.com/official-stockfish/fishtest/blob/master/server/fishtest/rundb.py#L1108
https://github.com/official-stockfish/fishtest/blob/master/worker/worker.py#L800

the server code is missing the 16MB ?

Stockfish will use more than one net with
official-stockfish/Stockfish#4915

Get all the couples "option" and "net names" from the output of the
`stockfish uci` command.

Raise worker version to 227 (also server side)
@ppigazzini
Copy link
Collaborator Author

Tested with workers: msys2, linux (python 3.6.8) with:

  • sf_11 vs master
  • sf_classical vs master
  • sf_12 vs master
  • SF_NNUE vs master
  • DualNNUE-1100-pr vs master

DualNNUE-1100-pr requires 'option.EvalFile=nn-0000000000a0.nnue', 'option.EvalFileSmall=nn-c01dc0ffeede.nnue'

image

@ppigazzini ppigazzini merged commit 81d23f7 into official-stockfish:master Feb 23, 2024
19 checks passed
@ppigazzini ppigazzini deleted the eval_file_small branch February 23, 2024 22:28
@ppigazzini
Copy link
Collaborator Author

Triggered the worker update, of course.

@Disservin
Copy link
Member

Thanks. I made a PR for the according Stockfish changes.

Disservin added a commit to official-stockfish/Stockfish that referenced this pull request Feb 24, 2024
Since official-stockfish/fishtest#1870 has been merged
it's time for this update.

5k Fixed Games showed no problems.
https://tests.stockfishchess.org/tests/view/65d9cc274c0e22b904f574d7

closes #5068

No functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update code change to account external change (Stockfish, book etc.) worker update code changes requiring a worker update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants